Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION(273742@main): LinkedIn "…" menu does not populate on click #24881

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Feb 21, 2024

71b8fba

REGRESSION(273742@main): LinkedIn "…" menu does not populate on click
https://bugs.webkit.org/show_bug.cgi?id=269848
rdar://123264559

Reviewed by Cameron McCormack.

The menu on LinkedIn transitions the `visibility` CSS property.

Do a partial revert of 273742@main to revert only the animation wrapper change for the `visibility` property, since it has caused changes that are timing sensitive for the site.

Imported WPT that also regressed along with 273742@main to avoid regressing this again.

* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation.html: Added.
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Canonical link: https://commits.webkit.org/275120@main

ad647e1

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m requested a review from graouts as a code owner February 21, 2024 16:33
@nt1m nt1m self-assigned this Feb 21, 2024
@nt1m nt1m added the Animations Bugs related to CSS + SVG animations and transitions label Feb 21, 2024
@heycam
Copy link
Contributor

heycam commented Feb 21, 2024

But let's make a test, which should be straightforward.

@nt1m nt1m force-pushed the eng/REGRESSION-273742main-LinkedIn--menu-does-not-populate-on-click branch from 0bc36d8 to ad647e1 Compare February 21, 2024 18:01
@nt1m nt1m added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Feb 21, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 275120@main (71b8fba): https://commits.webkit.org/275120@main

Reviewed commits have been landed. Closing PR #24881 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Feb 21, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-273742main-LinkedIn--menu-does-not-populate-on-click branch from ad647e1 to 71b8fba Compare February 21, 2024 19:50
@webkit-commit-queue webkit-commit-queue merged commit 71b8fba into WebKit:main Feb 21, 2024
@nt1m nt1m deleted the eng/REGRESSION-273742main-LinkedIn--menu-does-not-populate-on-click branch February 21, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Animations Bugs related to CSS + SVG animations and transitions
Projects
None yet
4 participants