Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebaseline negative-overflow-002.html on iOS due to RTL bugs #24905

Merged

Conversation

fantasai
Copy link
Contributor

@fantasai fantasai commented Feb 21, 2024

43c8390

Rebaseline negative-overflow-002.html on iOS due to RTL bugs
https://bugs.webkit.org/show_bug.cgi?id=269116
rdar://122678250

Reviewed by Ryosuke Niwa.

Rebaselines negative-overflow-002.html to have various 15px differences on iOS.

These seem to be due to incorrect handling of lefhand scrollbars when
calculating the scrollable area; iOS gives different results because it
has righthand scrollbars even in RTL.

This is a follow-up to https://commits.webkit.org/273737@main

* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: Added.

Canonical link: https://commits.webkit.org/275526@main

b3a19ee

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@fantasai fantasai self-assigned this Feb 21, 2024
@fantasai fantasai added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 21, 2024
@@ -0,0 +1,406 @@
1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty silly expected result. Can the test use a

for the scrolled contents rather than a bunch of newlines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a bunch of numbered boxes. The numbers help you understand the test: http://wpt.live/css/css-flexbox/negative-overflow-002.html

@fantasai fantasai added Layout and Rendering For bugs with layout and rendering of Web pages. request-merge-queue Request a pull request to be added to merge-queue once ready and removed New Bugs Unclassified bugs are placed in this component until the correct component can be determined. labels Feb 22, 2024
@fantasai fantasai force-pushed the negative-overflow-test-rebaseline branch from 5f0c57e to b3a19ee Compare February 27, 2024 22:25
@fantasai fantasai added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. and removed Layout and Rendering For bugs with layout and rendering of Web pages. labels Feb 27, 2024
@fantasai fantasai added merge-queue Applied to send a pull request to merge-queue and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Mar 1, 2024
https://bugs.webkit.org/show_bug.cgi?id=269116
rdar://122678250

Reviewed by Ryosuke Niwa.

Rebaselines negative-overflow-002.html to have various 15px differences on iOS.

These seem to be due to incorrect handling of lefhand scrollbars when
calculating the scrollable area; iOS gives different results because it
has righthand scrollbars even in RTL.

This is a follow-up to https://commits.webkit.org/273737@main

* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: Added.

Canonical link: https://commits.webkit.org/275526@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275526@main (43c8390): https://commits.webkit.org/275526@main

Reviewed commits have been landed. Closing PR #24905 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 43c8390 into WebKit:main Mar 1, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 1, 2024
@fantasai fantasai deleted the negative-overflow-test-rebaseline branch March 1, 2024 01:34
@fantasai fantasai added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases and removed New Bugs Unclassified bugs are placed in this component until the correct component can be determined. labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
5 participants