-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebaseline negative-overflow-002.html on iOS due to RTL bugs #24905
Rebaseline negative-overflow-002.html on iOS due to RTL bugs #24905
Conversation
EWS run on previous version of this PR (hash 5f0c57e) |
@@ -0,0 +1,406 @@ | |||
1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty silly expected result. Can the test use a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually a bunch of numbered boxes. The numbers help you understand the test: http://wpt.live/css/css-flexbox/negative-overflow-002.html
5f0c57e
to
b3a19ee
Compare
EWS run on current version of this PR (hash b3a19ee) |
https://bugs.webkit.org/show_bug.cgi?id=269116 rdar://122678250 Reviewed by Ryosuke Niwa. Rebaselines negative-overflow-002.html to have various 15px differences on iOS. These seem to be due to incorrect handling of lefhand scrollbars when calculating the scrollable area; iOS gives different results because it has righthand scrollbars even in RTL. This is a follow-up to https://commits.webkit.org/273737@main * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: Added. Canonical link: https://commits.webkit.org/275526@main
b3a19ee
to
43c8390
Compare
Committed 275526@main (43c8390): https://commits.webkit.org/275526@main Reviewed commits have been landed. Closing PR #24905 and removing active labels. |
43c8390
b3a19ee