Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB can be removed #24939

Merged
merged 1 commit into from
Mar 11, 2024
Merged

ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB can be removed #24939

merged 1 commit into from
Mar 11, 2024

Conversation

pgorszkowski-igalia
Copy link
Contributor

@pgorszkowski-igalia pgorszkowski-igalia commented Feb 22, 2024 •
edited by webkit-early-warning-system
Loading

e8537b3

ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB  can be removed
https://bugs.webkit.org/show_bug.cgi?id=269835

Reviewed by Nikolas Zimmermann.

After #23663 we can remove ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB.
It is enabled for all platforms.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::read):
* Source/WebCore/platform/graphics/ColorConversion.cpp:
(WebCore::convertAndResolveColorComponents):
* Source/WebCore/platform/graphics/DestinationColorSpace.cpp:
(WebCore::DestinationColorSpace::LinearSRGB):
(WebCore::operator<<):
* Source/WebCore/platform/graphics/DestinationColorSpace.h:
* Source/WebCore/platform/graphics/PlatformColorSpace.h:
* Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp:
(WebCore::ImageBufferCairoBackend::transformToColorSpace):
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyMask):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.cpp:
(WebCore::LegacyRenderSVGResourceMasker::applyResource):
* Source/WebCore/svg/graphics/filters/SVGFilter.cpp:
(WebCore::buildFilterEffectsGraph):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/275911@main

dbf5b98

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
❌ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@pgorszkowski-igalia pgorszkowski-igalia self-assigned this Feb 22, 2024
@pgorszkowski-igalia pgorszkowski-igalia added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 22, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 22, 2024 •
edited
Loading

EWS run on current version of this PR (hash dbf5b98)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
❌ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

nikolaszimmermann
nikolaszimmermann approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me.

@pgorszkowski-igalia pgorszkowski-igalia added the request-merge-queue Request a pull request to be added to merge-queue once ready label Feb 23, 2024
@Ahmad-S792 Ahmad-S792 added merge-queue Applied to send a pull request to merge-queue and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Mar 11, 2024
@pgorszkowski-igalia
ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB can be removed
e8537b3 
https://bugs.webkit.org/show_bug.cgi?id=269835

Reviewed by Nikolas Zimmermann.

After WebKit#23663 we can remove ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB.
It is enabled for all platforms.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::read):
* Source/WebCore/platform/graphics/ColorConversion.cpp:
(WebCore::convertAndResolveColorComponents):
* Source/WebCore/platform/graphics/DestinationColorSpace.cpp:
(WebCore::DestinationColorSpace::LinearSRGB):
(WebCore::operator<<):
* Source/WebCore/platform/graphics/DestinationColorSpace.h:
* Source/WebCore/platform/graphics/PlatformColorSpace.h:
* Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp:
(WebCore::ImageBufferCairoBackend::transformToColorSpace):
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyMask):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.cpp:
(WebCore::LegacyRenderSVGResourceMasker::applyResource):
* Source/WebCore/svg/graphics/filters/SVGFilter.cpp:
(WebCore::buildFilterEffectsGraph):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/275911@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB--can-be-removed branch from dbf5b98 to e8537b3 Compare March 11, 2024 17:01
@webkit-commit-queue
Copy link
Collaborator

Committed 275911@main (e8537b3): https://commits.webkit.org/275911@main

Reviewed commits have been landed. Closing PR #24939 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 11, 2024
@webkit-commit-queue webkit-commit-queue merged commit e8537b3 into WebKit:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolaszimmermann nikolaszimmermann nikolaszimmermann approved these changes

@magomez magomez Awaiting requested review from magomez magomez is a code owner

@zdobersek zdobersek Awaiting requested review from zdobersek zdobersek is a code owner

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@shallawa shallawa Awaiting requested review from shallawa

Assignees

@pgorszkowski-igalia pgorszkowski-igalia

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
5 participants
@pgorszkowski-igalia @webkit-early-warning-system @webkit-commit-queue @nikolaszimmermann @Ahmad-S792