Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AX][GTK] Implement Text interface for document-web #24956

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GeorgesStavracas
Copy link
Contributor

@GeorgesStavracas GeorgesStavracas commented Feb 22, 2024

2a84947

[AX][GTK] Implement Text interface for document-web
https://bugs.webkit.org/show_bug.cgi?id=268154

Reviewed by NOBODY (OOPS!).

This patch changes slightly how the roles reported by the AT-SPI DOM
tree are available. The goal is to unify how browsers report roles on
their accessible trees. It makes WebKit mostly match what Firefox and
Chromium do.

It is based on three general rules discussed with Orca developers:

 1. Accessible objects that implements Text must also implement Hypertext
 2. Children of Hypertext implementors must implement Hyperlink
 3. The document-web object must implement Text

In practice, this makes all accessible objects under the document-web
object implement Hyperlink, and many more implement Text now.

* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::interfacesForObject):

2a84947

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug ❌ πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 ❌ πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  watch-sim

https://bugs.webkit.org/show_bug.cgi?id=268154

Reviewed by NOBODY (OOPS!).

This patch changes slightly how the roles reported by the AT-SPI DOM
tree are available. The goal is to unify how browsers report roles on
their accessible trees. It makes WebKit mostly match what Firefox and
Chromium do.

It is based on three general rules discussed with Orca developers:

 1. Accessible objects that implements Text must also implement Hypertext
 2. Children of Hypertext implementors must implement Hyperlink
 3. The document-web object must implement Text

In practice, this makes all accessible objects under the document-web
object implement Hyperlink, and many more implement Text now.

* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::interfacesForObject):
@GeorgesStavracas GeorgesStavracas requested a review from a team as a code owner February 22, 2024 17:55
@GeorgesStavracas GeorgesStavracas self-assigned this Feb 22, 2024
@GeorgesStavracas GeorgesStavracas added the Accessibility For bugs related to accessibility. label Feb 22, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 22, 2024
@GeorgesStavracas GeorgesStavracas marked this pull request as draft February 22, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility For bugs related to accessibility. merging-blocked Applied to prevent a change from being merged
Projects
None yet
3 participants