Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gardening][view-transitions] Unskip tests no longer asserting on iOS #24986

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[Gardening][view-transitions] Unskip tests no longer asserting on iOS #24986

merged 1 commit into from
Feb 23, 2024

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Feb 23, 2024 •
edited by webkit-early-warning-system

@nt1m nt1m self-assigned this Feb 23, 2024
@nt1m nt1m added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 23, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash c00f9e9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@nt1m nt1m added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Feb 23, 2024
@nt1m
[Gardening][view-transitions] Unskip tests no longer asserting on iOS
4cb1306 
https://bugs.webkit.org/show_bug.cgi?id=269749
rdar://123266095

Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/275213@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-274957main--MacOS-iOS-Debug-wk2--2x-importedw3cweb-platform-testscsscss-view-transitions-tests-are-constant-crash branch from c00f9e9 to 4cb1306 Compare February 23, 2024 02:05
@webkit-commit-queue
Copy link
Collaborator

Test gardening commit 275213@main (4cb1306): https://commits.webkit.org/275213@main

Reviewed commits have been landed. Closing PR #24986 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4cb1306 into WebKit:main Feb 23, 2024
@webkit-commit-queue webkit-commit-queue removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 23, 2024
@nt1m nt1m deleted the eng/REGRESSION-274957main--MacOS-iOS-Debug-wk2--2x-importedw3cweb-platform-testscsscss-view-transitions-tests-are-constant-crash branch February 23, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nt1m nt1m

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
3 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue