Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanAttributeName doesn't need to check for "is" content attribute #25084

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Feb 26, 2024

@rniwa rniwa requested a review from cdumez as a code owner February 26, 2024 06:25
@rniwa rniwa self-assigned this Feb 26, 2024
@rniwa rniwa added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Feb 26, 2024
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me too.

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 26, 2024
https://bugs.webkit.org/show_bug.cgi?id=270066

Reviewed by Chris Dumez and Yusuke Suzuki.

Since we don't support "is" content attribute, we don't need to check for its presence.

* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::scanAttributeName):

Canonical link: https://commits.webkit.org/275331@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275331@main (5590366): https://commits.webkit.org/275331@main

Reviewed commits have been landed. Closing PR #25084 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5590366 into WebKit:main Feb 26, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 26, 2024
@rniwa rniwa deleted the fix270066 branch February 26, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
5 participants