REGRESSION(275377@main): [Win] GLContext::makeContextCurrent calls purecall for WebGL tests #25188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujii
added
the
Platform
|
EWS run on current version of this PR (hash 2321db4)
|
fujii
added
the
unsafe-merge-queue
…recall for WebGL tests https://bugs.webkit.org/show_bug.cgi?id=270186 Unreviewed crash fix. 275377@main introduced GLContextWrapper class to track the current GL context. ~GLContextWrapper unsets the current context if it is `this` context. GraphicsContextGLTextureMapperANGLE class inherits both GraphicsContextGLANGLE and GLContextWrapper classes in the following order. > class GraphicsContextGLTextureMapperANGLE : public GraphicsContextGLANGLE, public GLContextWrapper { Thus, destructors are called in the following order 1. ~GraphicsContextGLTextureMapperANGLE 2. ~GLContextWrapper 3. ~GraphicsContextGLANGLE ~GLContextWrapper unsets the current context, but ~GraphicsContextGLANGLE makes `this` context current again. GLContextWrapper base class should be before GraphicsContextGLANGLE. * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h: Canonical link: https://commits.webkit.org/275402@main
webkit-commit-queue
force-pushed
the
eng/REGRESSION275377main-Win-GLContextmakeContextCurrent-calls-purecall-for-WebGL-tests
branch
from
2321db4
to
cc42f3b
Compare
|
Committed 275402@main (cc42f3b): https://commits.webkit.org/275402@main Reviewed commits have been landed. Closing PR #25188 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc42f3b
2321db4
🧪 wpe-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 mac-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 api-gtk