Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedPDF] Annotation hover rectangle is wrong on rotated pages #25189

Conversation

sammygill
Copy link
Contributor

@sammygill sammygill commented Feb 27, 2024

a7d90be

[UnifiedPDF] Annotation hover rectangle is wrong on rotated pages
https://bugs.webkit.org/show_bug.cgi?id=270191
rdar://122931284

Reviewed by Simon Fraser.

This appears to be the same issue that 275351@main fixed for selections
but this time for annotations. To make sure that our painting code
displays the blue rectangle properly we need to factor out the rotation
that is implicit in bounds of the annotation that we get back from
PDFKit.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintPDFContent):

Canonical link: https://commits.webkit.org/275411@main

e40472e

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
  πŸ§ͺ ios-wk2-wpt βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@sammygill sammygill self-assigned this Feb 27, 2024
@sammygill sammygill added the PDF For bugs in WebKit's built-in PDF support. label Feb 27, 2024
Copy link
Member

@aprotyas aprotyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sammygill sammygill added the merge-queue Applied to send a pull request to merge-queue label Feb 27, 2024
https://bugs.webkit.org/show_bug.cgi?id=270191
rdar://122931284

Reviewed by Simon Fraser.

This appears to be the same issue that 275351@main fixed for selections
but this time for annotations. To make sure that our painting code
displays the blue rectangle properly we need to factor out the rotation
that is implicit in bounds of the annotation that we get back from
PDFKit.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintPDFContent):

Canonical link: https://commits.webkit.org/275411@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/UnifiedPDF-Annotation-hover-rectangle-is-wrong-on-rotated-pages branch from e40472e to a7d90be Compare February 27, 2024 23:03
@webkit-commit-queue
Copy link
Collaborator

Committed 275411@main (a7d90be): https://commits.webkit.org/275411@main

Reviewed commits have been landed. Closing PR #25189 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a7d90be into WebKit:main Feb 27, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PDF For bugs in WebKit's built-in PDF support.
Projects
None yet
5 participants