Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash under ScrollingStateFixedNode::reconcileLayerPositionForViewportRect #25354

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Crash under ScrollingStateFixedNode::reconcileLayerPositionForViewportRect #25354

merged 1 commit into from
Mar 1, 2024

Conversation

nmoucht
Copy link
Contributor

@nmoucht nmoucht commented Mar 1, 2024 •
edited by webkit-early-warning-system
Loading

0c592c9

Crash under ScrollingStateFixedNode::reconcileLayerPositionForViewportRect
https://bugs.webkit.org/show_bug.cgi?id=270361
rdar://105887621

Reviewed by Simon Fraser.

We need a similar fix to #17453 as there is
the same crash signature under ScrollingStateFixedNode::reconcileLayerPositionForViewportRect
this time.

* Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::reconcileLayerPositionForViewportRect):

Canonical link: https://commits.webkit.org/275574@main

04af527

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nmoucht nmoucht requested a review from cdumez as a code owner March 1, 2024 18:59
@nmoucht nmoucht self-assigned this Mar 1, 2024
@nmoucht nmoucht added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 1, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 1, 2024 •
edited
Loading

EWS run on current version of this PR (hash 04af527)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nmoucht nmoucht requested a review from whsieh March 1, 2024 19:00
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 1, 2024
@nmoucht nmoucht added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Mar 1, 2024
@nmoucht
Crash under ScrollingStateFixedNode::reconcileLayerPositionForViewpor…
0c592c9 
…tRect

https://bugs.webkit.org/show_bug.cgi?id=270361
rdar://105887621

Reviewed by Simon Fraser.

We need a similar fix to WebKit#17453 as there is
the same crash signature under ScrollingStateFixedNode::reconcileLayerPositionForViewportRect
this time.

* Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::reconcileLayerPositionForViewportRect):

Canonical link: https://commits.webkit.org/275574@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Crash-under-ScrollingStateFixedNodereconcileLayerPositionForViewportRect branch from 04af527 to 0c592c9 Compare March 1, 2024 23:20
@webkit-commit-queue
Copy link
Collaborator

Committed 275574@main (0c592c9): https://commits.webkit.org/275574@main

Reviewed commits have been landed. Closing PR #25354 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0c592c9 into WebKit:main Mar 1, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@whsieh whsieh Awaiting requested review from whsieh

Assignees

@nmoucht nmoucht

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
5 participants
@nmoucht @webkit-early-warning-system @webkit-commit-queue @smfr @webkit-ews-buildbot