Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some media modules files are missing headers #25401

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Mar 4, 2024

@marcoscaceres marcoscaceres self-assigned this Mar 4, 2024
@marcoscaceres marcoscaceres added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Mar 4, 2024
Copy link
Member

@jyavenard jyavenard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need a review for those changes ; just something like Unreviewed build fixes

@jyavenard jyavenard added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 4, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 4, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #13931.

https://bugs.webkit.org/show_bug.cgi?id=270430
rdar://123988923

Reviewed by Jean-Yves Avenard.

Imported missing header files for media related things.

* Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp:
* Source/WebCore/Modules/mediasource/MediaSourceHandle.cpp:
* Source/WebCore/Modules/mediasource/MediaSourceHandle.h:

Canonical link: https://commits.webkit.org/275613@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Some-media-module-files-are-missing-headers branch from 04f9de2 to 094154f Compare March 4, 2024 08:00
@webkit-commit-queue
Copy link
Collaborator

Committed 275613@main (094154f): https://commits.webkit.org/275613@main

Reviewed commits have been landed. Closing PR #25401 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 094154f into WebKit:main Mar 4, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2024
@marcoscaceres marcoscaceres deleted the eng/Some-media-module-files-are-missing-headers branch March 4, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
5 participants