Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] A64DOpcode include <mutex> #25420

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[JSC] A64DOpcode include <mutex> #25420

merged 1 commit into from
Mar 4, 2024

Conversation

sideeffect42
Copy link

@sideeffect42 sideeffect42 commented Mar 4, 2024 •
edited by webkit-early-warning-system
Loading

56001e9

[JSC] A64DOpcode include <mutex>
https://bugs.webkit.org/show_bug.cgi?id=270394

Reviewed by Michael Catanzaro.

When UNIFIED_BUILDS are disabled, the build fails due to missing std::call_once.

* Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: include <mutex>.

Canonical link: https://commits.webkit.org/275630@main

b01de65

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@sideeffect42 sideeffect42 requested a review from a team as a code owner March 4, 2024 16:46
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 4, 2024 •
edited
Loading

EWS run on current version of this PR (hash b01de65)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2024
@mcatanzaro
[JSC] A64DOpcode include <mutex>
56001e9 
https://bugs.webkit.org/show_bug.cgi?id=270394

Reviewed by Michael Catanzaro.

When UNIFIED_BUILDS are disabled, the build fails due to missing std::call_once.

* Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: include <mutex>.

Canonical link: https://commits.webkit.org/275630@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275630@main (56001e9): https://commits.webkit.org/275630@main

Reviewed commits have been landed. Closing PR #25420 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 56001e9 into WebKit:main Mar 4, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2024
@sideeffect42 sideeffect42 deleted the jsc/a64dopcode-mutex branch March 4, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sideeffect42 @webkit-early-warning-system @webkit-commit-queue @mcatanzaro