Build fix: WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled #25421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddkilzer
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash efccb60)
|
ddkilzer
added
the
unsafe-merge-queue
…n Fuzzilli is enabled https://bugs.webkit.org/show_bug.cgi?id=269796 <rdar://123317614> Unreviewed build fix. Enabling Fuzzilli failed to compile and link with -fsanitize-coverage=trace-pc-guard. The fix is to have separate OTHER_CFLAGS and OTHER_LDFLAGS for Fuzzilli and LibFuzzer that both use the shared $(WK_SANITIZER_COVERAGE). * Configurations/Sanitizers.xcconfig: (WK_SANITIZER_OTHER_CFLAGS): - Rearrange switches. (WK_SANITIZER_OTHER_CPLUSPLUSFLAGS): - Remove $(WK_LIBFUZZER_OTHER_CPLUSPLUSFLAGS_$(ENABLE_LIBFUZZER)) as it is not used. (WK_SANITIZER_OTHER_LDFLAGS): - Add $(WK_FUZZILLI_OTHER_LDFLAGS_$(ENABLE_FUZZILLI)). (WK_SANITIZER_COVERAGE*): - Rename from WK_LIBFUZZER_COVERAGE. (WK_SANITIZER_COVERAGE_OTHER_FLAGS): Add. - This is shared between Fuzzilli and LibFuzzer. (WK_LIBFUZZER_OTHER_CFLAGS_YES): (WK_LIBFUZZER_OTHER_LDFLAGS_YES): (WK_FUZZILLI_OTHER_CFLAGS_YES): Add. (WK_FUZZILLI_OTHER_LDFLAGS_YES): Add. - Make use of $(WK_SANITIZER_COVERAGE_OTHER_FLAGS). Canonical link: https://commits.webkit.org/275632@main
webkit-commit-queue
force-pushed
the
eng/Build-fix-WK_LIBFUZZER_COVERAGE-should-default-to-trace-pc-guard-with-Fuzzilli
branch
from
efccb60
to
b3a8dd3
Compare
|
Committed 275632@main (b3a8dd3): https://commits.webkit.org/275632@main Reviewed commits have been landed. Closing PR #25421 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
ddkilzer
deleted the
eng/Build-fix-WK_LIBFUZZER_COVERAGE-should-default-to-trace-pc-guard-with-Fuzzilli
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b3a8dd3
efccb60
🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 api-gtk