Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer] Crash after 10 seconds on watchdog thread due to deadlock deep inside GStreamer #25423

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

philn
Copy link
Member

@philn philn commented Mar 4, 2024

755898f

[GStreamer] Crash after 10 seconds on watchdog thread due to deadlock deep inside GStreamer
https://bugs.webkit.org/show_bug.cgi?id=260796

Reviewed by Xabier Rodriguez-Calvar.

Disable on-disk buffering for looping videos, due to high risks of deadlocking. The whole on-disk
buffering feature is doomed to disappear eventually anyway, since decodebin3/playbin3 have regressed
in that regard (by design).

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateDownloadBufferingFlag):

Canonical link: https://commits.webkit.org/275786@main

c7635ca

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@philn philn self-assigned this Mar 4, 2024
@philn philn added the Media Bugs related to the HTML 5 Media elements. label Mar 4, 2024
@philn philn requested a review from calvaris March 4, 2024 17:10
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 4, 2024
@philn philn marked this pull request as draft March 4, 2024 19:52
@philn philn removed the merging-blocked Applied to prevent a change from being merged label Mar 5, 2024
@philn philn marked this pull request as ready for review March 5, 2024 11:48
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2024
… deep inside GStreamer

https://bugs.webkit.org/show_bug.cgi?id=260796

Reviewed by Xabier Rodriguez-Calvar.

Disable on-disk buffering for looping videos, due to high risks of deadlocking. The whole on-disk
buffering feature is doomed to disappear eventually anyway, since decodebin3/playbin3 have regressed
in that regard (by design).

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateDownloadBufferingFlag):

Canonical link: https://commits.webkit.org/275786@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275786@main (755898f): https://commits.webkit.org/275786@main

Reviewed commits have been landed. Closing PR #25423 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 755898f into WebKit:main Mar 7, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2024
@philn philn deleted the eng/260796 branch March 7, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
5 participants