Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Archiving Test Results, visionOS Should be a Supported Platform #25437

Merged
merged 1 commit into from
Mar 4, 2024
Merged

When Archiving Test Results, visionOS Should be a Supported Platform #25437

merged 1 commit into from
Mar 4, 2024

Conversation

chgibb-apple
Copy link
Contributor

@chgibb-apple chgibb-apple commented Mar 4, 2024 •
edited by webkit-early-warning-system
Loading

66ad17a

When Archiving Test Results, visionOS Should be a Supported Platform
https://bugs.webkit.org/show_bug.cgi?id=270464
rdar://124022341

Reviewed by Ryan Haddad.

When archiving test results, visionOS should be a supported platform.

* Tools/CISupport/test-result-archive:
(archive_test_results):

Canonical link: https://commits.webkit.org/275658@main

c0fd435

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@chgibb-apple chgibb-apple self-assigned this Mar 4, 2024
@chgibb-apple chgibb-apple added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Mar 4, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 4, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 04625b9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🧪 api-ios   🧪 mac-wk2 ⏳ 🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
  🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
  🛠 watch-sim

@ryanhaddad
Copy link
Contributor

Thanks! Would you please add it to https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/test-result-archive#L79 as well?

@chgibb-apple chgibb-apple force-pushed the eng/When-Archiving-Test-Results-visionOS-Should-be-a-Supported-Platform branch from 04625b9 to c0fd435 Compare March 4, 2024 19:33
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 4, 2024 •
edited
Loading

EWS run on current version of this PR (hash c0fd435)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@chgibb-apple
Copy link
Contributor Author

Thanks! Would you please add it to https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/test-result-archive#L79 as well?

Done.

@chgibb-apple chgibb-apple added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 4, 2024
@ryanhaddad ryanhaddad added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 4, 2024
@chgibb-apple @ryanhaddad
When Archiving Test Results, visionOS Should be a Supported Platform
66ad17a 
https://bugs.webkit.org/show_bug.cgi?id=270464
rdar://124022341

Reviewed by Ryan Haddad.

When archiving test results, visionOS should be a supported platform.

* Tools/CISupport/test-result-archive:
(archive_test_results):

Canonical link: https://commits.webkit.org/275658@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/When-Archiving-Test-Results-visionOS-Should-be-a-Supported-Platform branch from c0fd435 to 66ad17a Compare March 4, 2024 23:57
@webkit-commit-queue
Copy link
Collaborator

Committed 275658@main (66ad17a): https://commits.webkit.org/275658@main

Reviewed commits have been landed. Closing PR #25437 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 66ad17a into WebKit:main Mar 4, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhaddad ryanhaddad ryanhaddad approved these changes

@aj062 aj062 Awaiting requested review from aj062 aj062 is a code owner

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@chgibb-apple chgibb-apple

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@chgibb-apple @webkit-early-warning-system @ryanhaddad @webkit-commit-queue