Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B3::ReduceStrength is overly conservative at applying specializeSelect #25539

Conversation

kmiller68
Copy link
Contributor

@kmiller68 kmiller68 commented Mar 6, 2024

@kmiller68 kmiller68 requested a review from a team as a code owner March 6, 2024 17:46
@kmiller68 kmiller68 self-assigned this Mar 6, 2024
@kmiller68 kmiller68 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Mar 6, 2024
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@kmiller68 kmiller68 added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 6, 2024
@Constellation Constellation added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 6, 2024
https://bugs.webkit.org/show_bug.cgi?id=270577
rdar://124146878

Reviewed by Justin Michaud.

Right now it only applies if both outputs from a select are constant. The comment
and testing indicates this is profitable as long as one of the two outputs is a constant.
This looks like a 1.7% speedup on JS3.

* Source/JavaScriptCore/b3/B3ReduceStrength.cpp:

Canonical link: https://commits.webkit.org/275765@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/B3ReduceStrength-is-overly-conservative-at-applying-specializeSelect branch from e6365b5 to 3e74b00 Compare March 6, 2024 23:14
@webkit-commit-queue
Copy link
Collaborator

Committed 275765@main (3e74b00): https://commits.webkit.org/275765@main

Reviewed commits have been landed. Closing PR #25539 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3e74b00 into WebKit:main Mar 6, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
5 participants