Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Do not use temp RegisterID when initializing local FunctionDeclaration #25598

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[JSC] Do not use temp RegisterID when initializing local FunctionDeclaration #25598

merged 1 commit into from
Mar 8, 2024

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Mar 7, 2024 •
edited by webkit-early-warning-system
Loading

347b11e

[JSC] Do not use temp RegisterID when initializing local FunctionDeclaration
https://bugs.webkit.org/show_bug.cgi?id=270665
rdar://124236096

Reviewed by Justin Michaud.

Let's avoid unnecessary mov. We can initialize local RegisterID directly for FunctionDeclaration.

* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):

Canonical link: https://commits.webkit.org/275818@main

74640c1

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@Constellation Constellation requested a review from a team as a code owner March 7, 2024 23:14
@Constellation Constellation self-assigned this Mar 7, 2024
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Mar 7, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 7, 2024 •
edited
Loading

EWS run on current version of this PR (hash 74640c1)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

justinmichaud
justinmichaud approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 8, 2024
@Constellation
[JSC] Do not use temp RegisterID when initializing local FunctionDecl…
347b11e 
…aration

https://bugs.webkit.org/show_bug.cgi?id=270665
rdar://124236096

Reviewed by Justin Michaud.

Let's avoid unnecessary mov. We can initialize local RegisterID directly for FunctionDeclaration.

* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):

Canonical link: https://commits.webkit.org/275818@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Do-not-use-temp-RegisterID-when-initializing-local-FunctionDeclaration branch from 74640c1 to 347b11e Compare March 8, 2024 02:44
@webkit-commit-queue
Copy link
Collaborator

Committed 275818@main (347b11e): https://commits.webkit.org/275818@main

Reviewed commits have been landed. Closing PR #25598 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 347b11e into WebKit:main Mar 8, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmichaud justinmichaud justinmichaud approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @justinmichaud