Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows debug build after 275825@main #25654

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Fix Windows debug build after 275825@main #25654

merged 1 commit into from
Mar 9, 2024

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Mar 8, 2024 •
edited by webkit-early-warning-system
Loading

@donny-dont donny-dont self-assigned this Mar 8, 2024
@donny-dont donny-dont added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Mar 8, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 8, 2024 •
edited
Loading

EWS run on current version of this PR (hash 29a2d26)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@donny-dont donny-dont marked this pull request as ready for review March 8, 2024 23:41
@donny-dont donny-dont added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 8, 2024
@donny-dont
Fix Windows debug build after 275825@main
9217a22 
https://bugs.webkit.org/show_bug.cgi?id=270720

Unreviewed build fix.

Add a missing `HAVE(IOSURFACE)` guard.

* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

Canonical link: https://commits.webkit.org/275860@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-Windows-debug-build-after-275825main branch from 29a2d26 to 9217a22 Compare March 9, 2024 00:00
@webkit-commit-queue
Copy link
Collaborator

Committed 275860@main (9217a22): https://commits.webkit.org/275860@main

Reviewed commits have been landed. Closing PR #25654 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9217a22 into WebKit:main Mar 9, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 9, 2024
@foopoiuyt foopoiuyt mentioned this pull request Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@donny-dont donny-dont

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
3 participants
@donny-dont @webkit-early-warning-system @webkit-commit-queue