Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visionOS] LinearMediaPlayer does not present audio and text track options #25661

Merged
merged 1 commit into from
Mar 9, 2024
Merged

[visionOS] LinearMediaPlayer does not present audio and text track options #25661

merged 1 commit into from
Mar 9, 2024

Conversation

aestes
Copy link
Contributor

@aestes aestes commented Mar 9, 2024 •
edited by webkit-early-warning-system
Loading

ad43bc6

[visionOS] LinearMediaPlayer does not present audio and text track options
https://bugs.webkit.org/show_bug.cgi?id=270727
rdar://124308729

Reviewed by Eric Carlson.

When introducing PlaybackSessionInterfaceLMK we neglected to provide implementations for
{audio, legible}MediaSelectionOptionsChanged, resulting in LinearMediaPlayer not presenting these
options in its UI.

Implemented these functions as well as the delegate callbacks to learn when the user changes tracks.

* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h:
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm:
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setAudioTrack:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setLegibleTrack:]):
(WebKit::PlaybackSessionInterfaceLMK::audioMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionInterfaceLMK::legibleMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionInterfaceLMK::audioMediaSelectionIndexChanged):
(WebKit::PlaybackSessionInterfaceLMK::legibleMediaSelectionIndexChanged):
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:

Canonical link: https://commits.webkit.org/275885@main

5b2947f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@aestes aestes requested a review from cdumez as a code owner March 9, 2024 02:15
@aestes aestes self-assigned this Mar 9, 2024
@aestes aestes added the Media Bugs related to the HTML 5 Media elements. label Mar 9, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 9, 2024 •
edited
Loading

EWS run on current version of this PR (hash 5b2947f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 9, 2024
@aestes aestes added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Mar 9, 2024
@aestes
[visionOS] LinearMediaPlayer does not present audio and text track op…
ad43bc6 
…tions

https://bugs.webkit.org/show_bug.cgi?id=270727
rdar://124308729

Reviewed by Eric Carlson.

When introducing PlaybackSessionInterfaceLMK we neglected to provide implementations for
{audio, legible}MediaSelectionOptionsChanged, resulting in LinearMediaPlayer not presenting these
options in its UI.

Implemented these functions as well as the delegate callbacks to learn when the user changes tracks.

* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h:
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm:
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setAudioTrack:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setLegibleTrack:]):
(WebKit::PlaybackSessionInterfaceLMK::audioMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionInterfaceLMK::legibleMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionInterfaceLMK::audioMediaSelectionIndexChanged):
(WebKit::PlaybackSessionInterfaceLMK::legibleMediaSelectionIndexChanged):
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:

Canonical link: https://commits.webkit.org/275885@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/visionOS-LinearMediaPlayer-does-not-present-audio-and-text-track-options branch from 5b2947f to ad43bc6 Compare March 9, 2024 21:14
@webkit-commit-queue
Copy link
Collaborator

Committed 275885@main (ad43bc6): https://commits.webkit.org/275885@main

Reviewed commits have been landed. Closing PR #25661 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ad43bc6 into WebKit:main Mar 9, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@jyavenard jyavenard Awaiting requested review from jyavenard

@jernoble jernoble Awaiting requested review from jernoble

@danae404 danae404 Awaiting requested review from danae404

Assignees

@aestes aestes

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
5 participants
@aestes @webkit-early-warning-system @webkit-commit-queue @eric-carlson @webkit-ews-buildbot