Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix older visionOS builds (linker) #25689

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Try to fix older visionOS builds (linker) #25689

merged 1 commit into from
Mar 10, 2024

Conversation

etiennesegonzac
Copy link
Contributor

@etiennesegonzac etiennesegonzac commented Mar 10, 2024 •
edited by webkit-early-warning-system
Loading

e8e13ca

Try to fix older visionOS builds (linker)
https://bugs.webkit.org/show_bug.cgi?id=270763
<rdar://124349498>

Reviewed by Tim Horton.

`WKSPreviewWindowController.h` needs to be part of `WebKitSwift.h`
because of the delegate. So it can't be included only based on a
(compile-time) feature flag.
Introduce a stub `WKSPreviewWindowController` instead for older SDKs,
where the feature is turned off anyway.

* Source/WebKit/WebKitSwift/Preview/PreviewWindowController.swift:

Canonical link: https://commits.webkit.org/275893@main

0ab2e55

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@etiennesegonzac etiennesegonzac self-assigned this Mar 10, 2024
@etiennesegonzac etiennesegonzac added the Media Bugs related to the HTML 5 Media elements. label Mar 10, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 10, 2024 •
edited
Loading

EWS run on current version of this PR (hash 0ab2e55)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@etiennesegonzac etiennesegonzac added the merge-queue Applied to send a pull request to merge-queue label Mar 10, 2024
@etiennesegonzac
Try to fix older visionOS builds (linker)
e8e13ca 
https://bugs.webkit.org/show_bug.cgi?id=270763
<rdar://124349498>

Reviewed by Tim Horton.

`WKSPreviewWindowController.h` needs to be part of `WebKitSwift.h`
because of the delegate. So it can't be included only based on a
(compile-time) feature flag.
Introduce a stub `WKSPreviewWindowController` instead for older SDKs,
where the feature is turned off anyway.

* Source/WebKit/WebKitSwift/Preview/PreviewWindowController.swift:

Canonical link: https://commits.webkit.org/275893@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Try-to-fix-older-visionOS-builds-linker branch from 0ab2e55 to e8e13ca Compare March 10, 2024 17:39
@webkit-commit-queue
Copy link
Collaborator

Committed 275893@main (e8e13ca): https://commits.webkit.org/275893@main

Reviewed commits have been landed. Closing PR #25689 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e8e13ca into WebKit:main Mar 10, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@MenloDorian MenloDorian Awaiting requested review from MenloDorian

Assignees

@etiennesegonzac etiennesegonzac

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@etiennesegonzac @webkit-early-warning-system @webkit-commit-queue @hortont424