Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[git-webkit revert] Temporarily disable reopening radars automatically #25729

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[git-webkit revert] Temporarily disable reopening radars automatically #25729

merged 1 commit into from
Mar 12, 2024

Conversation

briannafan
Copy link
Contributor

@briannafan briannafan commented Mar 11, 2024 •
edited by webkit-early-warning-system
Loading

6588b14

[git-webkit revert] Temporarily disable reopening radars automatically
https://bugs.webkit.org/show_bug.cgi?id=270803
rdar://124393291

Reviewed by Ryan Haddad.

Disable reopening radars until work in webkitbugspy is done.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py:
(Revert.relate_issues):

Canonical link: https://commits.webkit.org/275957@main

895fc5a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@briannafan briannafan self-assigned this Mar 11, 2024
@briannafan briannafan added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Mar 11, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 11, 2024 •
edited
Loading

EWS run on previous version of this PR (hash a88fa63)

Misc iOS, tvOS & watchOS macOS Linux Windows
  🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
  🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 webkitpy   🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-skia
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🧪 services   🛠 tv-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch
  🛠 watch-sim

@briannafan briannafan changed the title [git-webkit revert] Temporarily disable relating radars automatically [git-webkit revert] Temporarily disable reopening radars automatically Mar 11, 2024
@briannafan briannafan force-pushed the eng/git-webkit-revert-Temporarily-disable-relating-radars-automatically branch 2 times, most recently from 279d9d4 to 0ed205c Compare March 11, 2024 17:12
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 11, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 279d9d4)

Misc iOS, tvOS & watchOS macOS Linux Windows
  🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
  🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 webkitpy   🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-skia
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🧪 services   🛠 tv-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch
  🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 11, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 0ed205c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
✅ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-skia
⏳ 🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 tv ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🧪 services   🛠 tv-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch
  🛠 watch-sim

@briannafan briannafan added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 11, 2024
aproskuryakov
aproskuryakov reviewed Mar 11, 2024
View reviewed changes
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py Outdated
sys.stderr.write('Failed to re-open {}\n'.format(c_issue.link))
sys.stderr.write('{}\n'.format(str(e)))
c_issue.add_comment('{}, tracking revert in {}.'.format(revert_reason, r_issue.link))
# TODO: Reopen radars after rdar://124165667
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: WebKit style is to use FIXME, not TODO.

@briannafan briannafan force-pushed the eng/git-webkit-revert-Temporarily-disable-relating-radars-automatically branch from 0ed205c to 895fc5a Compare March 11, 2024 18:32
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 11, 2024 •
edited
Loading

EWS run on current version of this PR (hash 895fc5a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 12, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #14685.

@briannafan
[git-webkit revert] Temporarily disable reopening radars automatically
6588b14 
https://bugs.webkit.org/show_bug.cgi?id=270803
rdar://124393291

Reviewed by Ryan Haddad.

Disable reopening radars until work in webkitbugspy is done.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py:
(Revert.relate_issues):

Canonical link: https://commits.webkit.org/275957@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/git-webkit-revert-Temporarily-disable-relating-radars-automatically branch from 895fc5a to 6588b14 Compare March 12, 2024 05:03
@webkit-commit-queue
Copy link
Collaborator

Committed 275957@main (6588b14): https://commits.webkit.org/275957@main

Reviewed commits have been landed. Closing PR #25729 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6588b14 into WebKit:main Mar 12, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aproskuryakov aproskuryakov aproskuryakov left review comments

@ryanhaddad ryanhaddad ryanhaddad approved these changes

@facetothefate facetothefate Awaiting requested review from facetothefate facetothefate is a code owner

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@briannafan briannafan

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
6 participants
@briannafan @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @ryanhaddad @aproskuryakov