Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate more ivars from WKWebViewConfiguration to API::PageConfiguration #25891

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Mar 14, 2024

e7bb5f0

Migrate more ivars from WKWebViewConfiguration to API::PageConfiguration
https://bugs.webkit.org/show_bug.cgi?id=270990
rdar://124627697

Reviewed by Charlie Wolfe.

This is another step towards moving the PageConfiguration creation to
platform-independent code in WebPageProxy::createNewPage.

* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::incrementalRenderingSuppressionTimeout const):
(API::PageConfiguration::setIncrementalRenderingSuppressionTimeout):
(API::PageConfiguration::allowsJavaScriptMarkup const):
(API::PageConfiguration::setAllowsJavaScriptMarkup):
(API::PageConfiguration::convertsPositionStyleOnCopy const):
(API::PageConfiguration::setConvertsPositionStyleOnCopy):
(API::PageConfiguration::allowsMetaRefresh const):
(API::PageConfiguration::setAllowsMetaRefresh):
(API::PageConfiguration::allowUniversalAccessFromFileURLs const):
(API::PageConfiguration::setAllowUniversalAccessFromFileURLs):
(API::PageConfiguration::allowTopNavigationToDataURLs const):
(API::PageConfiguration::setAllowTopNavigationToDataURLs):
(API::PageConfiguration::needsStorageAccessFromFileURLsQuirk const):
(API::PageConfiguration::setNeedsStorageAccessFromFileURLsQuirk):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _incrementalRenderingSuppressionTimeout]):
(-[WKWebViewConfiguration _setIncrementalRenderingSuppressionTimeout:]):
(-[WKWebViewConfiguration _allowsJavaScriptMarkup]):
(-[WKWebViewConfiguration _setAllowsJavaScriptMarkup:]):
(-[WKWebViewConfiguration _allowUniversalAccessFromFileURLs]):
(-[WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:]):
(-[WKWebViewConfiguration _allowTopNavigationToDataURLs]):
(-[WKWebViewConfiguration _setAllowTopNavigationToDataURLs:]):
(-[WKWebViewConfiguration _convertsPositionStyleOnCopy]):
(-[WKWebViewConfiguration _setConvertsPositionStyleOnCopy:]):
(-[WKWebViewConfiguration _allowsMetaRefresh]):
(-[WKWebViewConfiguration _setAllowsMetaRefresh:]):
(-[WKWebViewConfiguration _needsStorageAccessFromFileURLsQuirk]):
(-[WKWebViewConfiguration _setNeedsStorageAccessFromFileURLsQuirk:]):

Canonical link: https://commits.webkit.org/276117@main

a40ea28

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac   πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ›  wpe-skia
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2   πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@achristensen07 achristensen07 self-assigned this Mar 14, 2024
@achristensen07 achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 14, 2024
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=270990
rdar://124627697

Reviewed by Charlie Wolfe.

This is another step towards moving the PageConfiguration creation to
platform-independent code in WebPageProxy::createNewPage.

* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::incrementalRenderingSuppressionTimeout const):
(API::PageConfiguration::setIncrementalRenderingSuppressionTimeout):
(API::PageConfiguration::allowsJavaScriptMarkup const):
(API::PageConfiguration::setAllowsJavaScriptMarkup):
(API::PageConfiguration::convertsPositionStyleOnCopy const):
(API::PageConfiguration::setConvertsPositionStyleOnCopy):
(API::PageConfiguration::allowsMetaRefresh const):
(API::PageConfiguration::setAllowsMetaRefresh):
(API::PageConfiguration::allowUniversalAccessFromFileURLs const):
(API::PageConfiguration::setAllowUniversalAccessFromFileURLs):
(API::PageConfiguration::allowTopNavigationToDataURLs const):
(API::PageConfiguration::setAllowTopNavigationToDataURLs):
(API::PageConfiguration::needsStorageAccessFromFileURLsQuirk const):
(API::PageConfiguration::setNeedsStorageAccessFromFileURLsQuirk):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _incrementalRenderingSuppressionTimeout]):
(-[WKWebViewConfiguration _setIncrementalRenderingSuppressionTimeout:]):
(-[WKWebViewConfiguration _allowsJavaScriptMarkup]):
(-[WKWebViewConfiguration _setAllowsJavaScriptMarkup:]):
(-[WKWebViewConfiguration _allowUniversalAccessFromFileURLs]):
(-[WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:]):
(-[WKWebViewConfiguration _allowTopNavigationToDataURLs]):
(-[WKWebViewConfiguration _setAllowTopNavigationToDataURLs:]):
(-[WKWebViewConfiguration _convertsPositionStyleOnCopy]):
(-[WKWebViewConfiguration _setConvertsPositionStyleOnCopy:]):
(-[WKWebViewConfiguration _allowsMetaRefresh]):
(-[WKWebViewConfiguration _setAllowsMetaRefresh:]):
(-[WKWebViewConfiguration _needsStorageAccessFromFileURLsQuirk]):
(-[WKWebViewConfiguration _setNeedsStorageAccessFromFileURLsQuirk:]):

Canonical link: https://commits.webkit.org/276117@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Migrate-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration branch from a40ea28 to e7bb5f0 Compare March 14, 2024 20:39
@webkit-commit-queue webkit-commit-queue merged commit e7bb5f0 into WebKit:main Mar 14, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 276117@main (e7bb5f0): https://commits.webkit.org/276117@main

Reviewed commits have been landed. Closing PR #25891 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
4 participants