Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPE][GTK] Fix clang warning about use of variable length arrays in C++ #25911

Merged
merged 1 commit into from
Mar 15, 2024
Merged

[WPE][GTK] Fix clang warning about use of variable length arrays in C++ #25911

merged 1 commit into from
Mar 15, 2024

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Mar 14, 2024 •
edited by webkit-early-warning-system

d02f043

[WPE][GTK] Fix clang warning about use of variable length arrays in C++
https://bugs.webkit.org/show_bug.cgi?id=271005

Reviewed by Adrian Perez de Castro.

We shouldn't use variable-length arrays in WebKit.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextURIScheme):

Canonical link: https://commits.webkit.org/276168@main

a95d996

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro requested a review from a team as a code owner March 14, 2024 22:34
@mcatanzaro mcatanzaro self-assigned this Mar 14, 2024
@mcatanzaro mcatanzaro added the WebKitGTK Bugs related to the Gtk API layer. label Mar 14, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 7e1c4ec)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 15, 2024
@mcatanzaro mcatanzaro removed the merging-blocked Applied to prevent a change from being merged label Mar 15, 2024
@mcatanzaro mcatanzaro force-pushed the eng/WPEGTK-Fix-clang-warning-about-use-of-variable-length-arrays-in-C branch from 7e1c4ec to a95d996 Compare March 15, 2024 15:22
@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Mar 15, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a95d996)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro
[WPE][GTK] Fix clang warning about use of variable length arrays in C++
d02f043 
https://bugs.webkit.org/show_bug.cgi?id=271005

Reviewed by Adrian Perez de Castro.

We shouldn't use variable-length arrays in WebKit.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextURIScheme):

Canonical link: https://commits.webkit.org/276168@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WPEGTK-Fix-clang-warning-about-use-of-variable-length-arrays-in-C branch from a95d996 to d02f043 Compare March 15, 2024 16:49
@webkit-commit-queue
Copy link
Collaborator

Committed 276168@main (d02f043): https://commits.webkit.org/276168@main

Reviewed commits have been landed. Closing PR #25911 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d02f043 into WebKit:main Mar 15, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

Assignees

@mcatanzaro mcatanzaro

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
5 participants
@mcatanzaro @webkit-early-warning-system @webkit-commit-queue @aperezdc @webkit-ews-buildbot