-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSS] Fix wrong proximity calculation for implicit @scope #25918
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mdubet:css-scoping-implicit-cascade
Mar 19, 2024
Merged
[CSS] Fix wrong proximity calculation for implicit @scope #25918
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mdubet:css-scoping-implicit-cascade
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 513e811) |
513e811
to
1eb3051
Compare
anttijk
approved these changes
Mar 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=270900 rdar://124640124 Reviewed by Antti Koivisto. The previous code was wrongly trying to locate the distance of the element to the @scope owner node (the <style> node), while it should locate the distance to the parent of the owner node. * LayoutTests/fast/css/scope-at-rule-expected.html: * LayoutTests/fast/css/scope-at-rule.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-implicit-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-implicit.html: * Source/WebCore/style/ElementRuleCollector.cpp: (WebCore::Style::ElementRuleCollector::scopeRulesMatch): Canonical link: https://commits.webkit.org/276345@main
1eb3051
to
7b99ea4
Compare
Committed 276345@main (7b99ea4): https://commits.webkit.org/276345@main Reviewed commits have been landed. Closing PR #25918 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7b99ea4
1eb3051