Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Extend JSBigInt::compare and JSBigInt::compareToDouble for Int64 and Int32 #25964

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[JSC] Extend JSBigInt::compare and JSBigInt::compareToDouble for Int64 and Int32 #25964

merged 1 commit into from
Mar 20, 2024

Conversation

hyjorc1
Copy link
Contributor

@hyjorc1 hyjorc1 commented Mar 15, 2024 •
edited by webkit-early-warning-system
Loading

f706066

[JSC] Extend JSBigInt::compare and JSBigInt::compareToDouble for Int64 and Int32
https://bugs.webkit.org/show_bug.cgi?id=271073
rdar://124706111

Reviewed by Keith Miller.

This patch extends JSBigInt::compare and JSBigInt::compareToDouble
for Int64 and Int32.

* Source/JavaScriptCore/runtime/JSBigInt.cpp:
(JSC::Int64BigIntImpl::Int64BigIntImpl):
(JSC::Int64BigIntImpl::isZero):
(JSC::Int64BigIntImpl::sign):
(JSC::Int64BigIntImpl::length):
(JSC::Int64BigIntImpl::digit):
(JSC::JSBigInt::compare):
(JSC::JSBigInt::compareToDouble):
* Source/JavaScriptCore/runtime/JSBigInt.h:

Canonical link: https://commits.webkit.org/276417@main

8ad48fd

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
⏳ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
⏳ 🧪 services ⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
⏳ 🛠 watch ⏳ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ⏳ 🛠 watch-sim ⏳ 🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 self-assigned this Mar 15, 2024
@hyjorc1 hyjorc1 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Mar 15, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 15, 2024 •
edited
Loading

EWS run on previous version of this PR (hash d3c1a9f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-skia
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64   🛠 tv ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
⏳ 🛠 tv-sim   🧪 api-gtk
⏳ 🛠 watch ✅ 🛠 jsc-armv7
⏳ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 marked this pull request as ready for review March 15, 2024 19:35
@hyjorc1 hyjorc1 requested a review from a team as a code owner March 15, 2024 19:35
@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from d3c1a9f to 7b2e4f7 Compare March 15, 2024 19:50
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 15, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 7b2e4f7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 tv-sim ⏳ 🧪 api-gtk
✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from 7b2e4f7 to b2bdf54 Compare March 19, 2024 16:48
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash b2bdf54)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv   🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
⏳ 🛠 watch ✅ 🛠 jsc-armv7
⏳ 🛠 watch-sim   🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from b2bdf54 to b94ac0b Compare March 19, 2024 16:50
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash b94ac0b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ⏳ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-skia
⏳ 🛠 🧪 jsc   🧪 api-ios loading 🧪 mac-wk2   🛠 gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
⏳ 🛠 tv-sim   🧪 api-gtk
⏳ 🛠 watch ⏳ 🛠 jsc-armv7
⏳ 🛠 watch-sim ⏳ 🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from b94ac0b to db1d04d Compare March 19, 2024 16:55
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash db1d04d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim   🧪 api-gtk
⏳ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from db1d04d to 85d75f2 Compare March 19, 2024 18:23
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 85d75f2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
⏳ 🛠 tv-sim   🧪 api-gtk
⏳ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

kmiller68
kmiller68 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with recommendations.

Source/JavaScriptCore/runtime/JSBigInt.cpp Outdated Show resolved Hide resolved
Source/JavaScriptCore/runtime/JSBigInt.cpp Show resolved Hide resolved
Source/JavaScriptCore/runtime/JSBigInt.cpp Outdated Show resolved Hide resolved
@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from 85d75f2 to 71c655c Compare March 19, 2024 20:04
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 71c655c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-skia
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 tv-sim ⏳ 🧪 api-gtk
  🛠 🧪 merge ⏳ 🛠 watch ❌ 🛠 jsc-armv7
⏳ 🛠 watch-sim ❌ 🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 added the merge-queue Applied to send a pull request to merge-queue label Mar 19, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Mar 19, 2024
@hyjorc1 hyjorc1 removed the merging-blocked Applied to prevent a change from being merged label Mar 19, 2024
@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from 71c655c to b5ea7cf Compare March 19, 2024 20:18
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash b5ea7cf)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-skia
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 tv-sim ✅ 🧪 api-gtk
  🛠 🧪 merge ⏳ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Mar 19, 2024
@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from b5ea7cf to 0d724d8 Compare March 19, 2024 23:34
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 0d724d8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
  🛠 ios-sim   🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 api-wpe
  🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
⏳ 🛠 🧪 jsc   🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv   🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
⏳ 🛠 watch ⏳ 🛠 jsc-armv7
⏳ 🛠 watch-sim ⏳ 🧪 jsc-armv7-tests

@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from 0d724d8 to 10b9352 Compare March 19, 2024 23:37
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on current version of this PR (hash 10b9352)

Misc iOS, tvOS & watchOS macOS Linux Windows
loading 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
loading 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
  🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 20, 2024
@hyjorc1 hyjorc1 removed the merging-blocked Applied to prevent a change from being merged label Mar 20, 2024
@hyjorc1 hyjorc1 force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from 10b9352 to 8ad48fd Compare March 20, 2024 16:22
@hyjorc1 hyjorc1 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Mar 20, 2024
@hyjorc1
[JSC] Extend JSBigInt::compare and JSBigInt::compareToDouble for Int6…
f706066 
…4 and Int32

https://bugs.webkit.org/show_bug.cgi?id=271073
rdar://124706111

Reviewed by Keith Miller.

This patch extends JSBigInt::compare and JSBigInt::compareToDouble
for Int64 and Int32.

* Source/JavaScriptCore/runtime/JSBigInt.cpp:
(JSC::Int64BigIntImpl::Int64BigIntImpl):
(JSC::Int64BigIntImpl::isZero):
(JSC::Int64BigIntImpl::sign):
(JSC::Int64BigIntImpl::length):
(JSC::Int64BigIntImpl::digit):
(JSC::JSBigInt::compare):
(JSC::JSBigInt::compareToDouble):
* Source/JavaScriptCore/runtime/JSBigInt.h:

Canonical link: https://commits.webkit.org/276417@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Extend-JSBigIntcompare-and-JSBigIntcompareToDouble-for-Int64-and-Int32 branch from 8ad48fd to f706066 Compare March 20, 2024 21:06
@webkit-commit-queue
Copy link
Collaborator

Committed 276417@main (f706066): https://commits.webkit.org/276417@main

Reviewed commits have been landed. Closing PR #25964 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 20, 2024
@webkit-commit-queue webkit-commit-queue merged commit f706066 into WebKit:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmiller68 kmiller68 kmiller68 approved these changes

Assignees

@hyjorc1 hyjorc1

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
5 participants
@hyjorc1 @webkit-early-warning-system @webkit-commit-queue @kmiller68 @webkit-ews-buildbot