Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge-Queue] Add step to close pull request #260

Merged
merged 0 commits into from Apr 7, 2022
Merged

[Merge-Queue] Add step to close pull request #260

merged 0 commits into from Apr 7, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Apr 7, 2022 •
edited by webkit-early-warning-system

e5975b7

[Merge-Queue] Add step to close pull request
https://bugs.webkit.org/show_bug.cgi?id=238949
<rdar://problem/91434587 >

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.close_pr): Make POST request to close PR.
(ClosePullRequest):
(ClosePullRequest.start): Ensure PR we're operating on is closed.
(ClosePullRequest.getResultSummary):
(ClosePullRequest.doStepIf): Only do step if operating on a PR.
(ClosePullRequest.hideStepIf): Hide step if skipping.
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/249393@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Apr 7, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Apr 7, 2022
@JonWBedard JonWBedard requested a review from aj062 April 7, 2022 18:36
aj062
aj062 approved these changes Apr 7, 2022
View reviewed changes
Tools/CISupport/ews-build/steps.py Outdated
self._addToLog('stdio', f"Failed to close PR {pr_number}. Unexpected response code from GitHub: {response.status_code}\n")
return False
except Exception as e:
self._addToLog('stdio', f"Error in closing PR {pr_number}\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to print e here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should, will add

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we haven't logged a similar exception in any of the other functions in GitHubMixin, I will propose a change that does this, but we should do all of them all at the same time.

@JonWBedard JonWBedard added the merge-queue Applied to send a pull request to merge-queue label Apr 7, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Merge-Queue-Add-step-to-close-pull-request branch from 4486cb6 to e5975b7 Compare April 7, 2022 19:56
@webkit-early-warning-system webkit-early-warning-system merged commit e5975b7 into WebKit:main Apr 7, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r292555 (249393@main): https://commits.webkit.org/249393@main

Reviewed commits have been landed. Closing #260 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Apr 7, 2022
@JonWBedard JonWBedard deleted the eng/Merge-Queue-Add-step-to-close-pull-request branch March 21, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj062 aj062 aj062 approved these changes

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@JonWBedard @webkit-early-warning-system @aj062