Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove containment and container query feature flags #26010

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Mar 16, 2024

6a88bee

Remove containment and container query feature flags
https://bugs.webkit.org/show_bug.cgi?id=259771
rdar://113323967

Reviewed by Tim Nguyen.

These have been enabled by default for a while now.

* LayoutTests/fast/css/contain-invalidate-if-disabled-expected.txt: Removed.
* LayoutTests/fast/css/contain-invalidate-if-disabled.html: Removed.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeContainerRule):
* Tools/DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/276247@main

a3f56c5

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ›  jsc-armv7
βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-armv7-tests

@annevk annevk self-assigned this Mar 16, 2024
@annevk annevk added the CSS Cascading Style Sheets implementation label Mar 16, 2024
@annevk annevk marked this pull request as ready for review March 17, 2024 07:25
@annevk annevk requested a review from JonWBedard as a code owner March 17, 2024 07:25
@annevk annevk added the merge-queue Applied to send a pull request to merge-queue label Mar 17, 2024
https://bugs.webkit.org/show_bug.cgi?id=259771
rdar://113323967

Reviewed by Tim Nguyen.

These have been enabled by default for a while now.

* LayoutTests/fast/css/contain-invalidate-if-disabled-expected.txt: Removed.
* LayoutTests/fast/css/contain-invalidate-if-disabled.html: Removed.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeContainerRule):
* Tools/DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/276247@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-containment-and-container-query-feature-flags branch from a3f56c5 to 6a88bee Compare March 17, 2024 08:07
@webkit-commit-queue
Copy link
Collaborator

Committed 276247@main (6a88bee): https://commits.webkit.org/276247@main

Reviewed commits have been landed. Closing PR #26010 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6a88bee into WebKit:main Mar 17, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 17, 2024
@annevk annevk deleted the eng/Remove-containment-and-container-query-feature-flags branch March 17, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
5 participants