Remove CSSCustomPropertiesAndValuesEnabled preference #26018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
added
the
WebCore Misc.
|
EWS run on previous version of this PR (hash a45f750) |
nt1m
approved these changes
Mar 18, 2024
annevk
force-pushed
the
eng/Remove-CSSCustomPropertiesAndValuesEnabled-preference
branch
from
a45f750
to
bc1b014
Compare
|
EWS run on current version of this PR (hash bc1b014) |
https://bugs.webkit.org/show_bug.cgi?id=271126 Reviewed by Tim Nguyen. It's been stable over a year. * LayoutTests/css-custom-properties-api/crash.html: * LayoutTests/css-custom-properties-api/cycles.html: * LayoutTests/css-custom-properties-api/inherits.html: * LayoutTests/css-custom-properties-api/initialValue.html: * LayoutTests/css-custom-properties-api/initialValueJS.html: * LayoutTests/css-custom-properties-api/inline.html: * LayoutTests/css-custom-properties-api/length.html: * LayoutTests/css-custom-properties-api/length2.html: * LayoutTests/css-custom-properties-api/registerProperty.html: * LayoutTests/fast/css-custom-paint/properties.html: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl: * Source/WebCore/css/DOMCSSNamespace+CSSPropertiesandValues.idl: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumePropertyRule): * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences CSSCustomPropertiesAndValuesEnabled]): (-[WebPreferences setCSSCustomPropertiesAndValuesEnabled:]): * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: Canonical link: https://commits.webkit.org/276260@main
webkit-commit-queue
force-pushed
the
eng/Remove-CSSCustomPropertiesAndValuesEnabled-preference
branch
from
bc1b014
to
014919f
Compare
|
Committed 276260@main (014919f): https://commits.webkit.org/276260@main Reviewed commits have been landed. Closing PR #26018 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
annevk
deleted the
eng/Remove-CSSCustomPropertiesAndValuesEnabled-preference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
014919f
bc1b014
🧪 wpe-wk2🛠 🧪 jsc🛠 🧪 jsc-arm64🧪 mac-AS-debug-wk2