Create header file for interface declaration #26055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvollan
added
the
WebKit Misc.
|
EWS run on previous version of this PR (hash 94db9d3)
|
🛠 wpe
pvollan
force-pushed
the
eng/Create-header-file-for-interface-declaration
branch
from
94db9d3
to
046595a
Compare
|
EWS run on current version of this PR (hash 046595a)
|
cdumez
approved these changes
Mar 18, 2024
|
Thanks for reviewing! |
szewai
reviewed
Mar 18, 2024
| #if USE(APPLE_INTERNAL_SDK) | ||
| #include <AccessibilityUtilities.h> | ||
| #else | ||
| @interface NSObject (UIAccessibilitySafeCategory) |
There was a problem hiding this comment.
Is this available on non-iOS family platform?
There was a problem hiding this comment.
Yes, I think it is available on other platforms too.
Thanks for reviewing!
szewai
approved these changes
Mar 18, 2024
webkit-ews-buildbot
added
the
merging-blocked
karlrackler
removed
the
merging-blocked
pvollan
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=271160 rdar://124950453 Reviewed by Sihui Liu and Chris Dumez. Guard against potential build issues, by moving interface declaration to a header file. * Source/WebKit/Platform/spi/Cocoa/AccessibilityUtilitiesSPI.h: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::postNotification): Canonical link: https://commits.webkit.org/276290@main
webkit-commit-queue
force-pushed
the
eng/Create-header-file-for-interface-declaration
branch
from
046595a
to
e653334
Compare
|
Committed 276290@main (e653334): https://commits.webkit.org/276290@main Reviewed commits have been landed. Closing PR #26055 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e653334
046595a
🧪 wpe-wk2🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🛠 watch