Move most LazyInitialized ivars from WKWebViewConfiguration to API::PageConfiguration #26177

achristensen07 · 2024-03-20T07:01:45Z

`9b4ec97`

Move most LazyInitialized ivars from WKWebViewConfiguration to API::PageConfiguration
https://bugs.webkit.org/show_bug.cgi?id=271301
rdar://125067469

Reviewed by Chris Dumez.

This is a step towards the API::PageConfiguration being made in WebPageProxy::createNewPage
rather than UIClient::createNewPage.

This new way of storing these objects is more robust against invalid use of WKWebViewConfiguration
if nil is set as the value of non-nullable objects, so the validate step is no longer needed
and the InvalidConfiguration API test needed some changes, but this should have no impact on
legitimate use of the API.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::Data::createBrowsingContextGroup):
(API::PageConfiguration::Data::createWebProcessPool):
(API::PageConfiguration::Data::createWebUserContentControllerProxy):
(API::PageConfiguration::Data::createWebPreferences):
(API::PageConfiguration::Data::createVisitedLinkStore):
(API::PageConfiguration::Data::createWebsitePolicies):
(API::PageConfiguration::create):
(API::PageConfiguration::browsingContextGroup const):
(API::PageConfiguration::processPool const):
(API::PageConfiguration::userContentController const):
(API::PageConfiguration::preferences const):
(API::PageConfiguration::pageToCloneSessionStorageFrom const):
(API::PageConfiguration::setPageToCloneSessionStorageFrom):
(API::PageConfiguration::visitedLinkStore const):
(API::PageConfiguration::websiteDataStore const):
(API::PageConfiguration::websiteDataStoreIfExists const):
(API::PageConfiguration::protectedWebsiteDataStore const):
(API::PageConfiguration::setWebsiteDataStore):
(API::PageConfiguration::defaultWebsitePolicies const):
(API::PageConfiguration::urlSchemeHandlerForURLScheme):
(API::PageConfiguration::setURLSchemeHandlerForURLScheme):
(API::PageConfiguration::lockdownModeEnabled const):
(API::PageConfiguration::delaysWebProcessLaunchUntilFirstLoad const):
(API::PageConfiguration::isLockdownModeExplicitlySet const):
(API::PageConfiguration::preferencesForGPUProcess const):
(API::PageConfiguration::preferencesForNetworkProcess const):
(API::PageConfiguration::PageConfiguration): Deleted.
(API::PageConfiguration::browsingContextGroup): Deleted.
(API::PageConfiguration::processPool): Deleted.
(API::PageConfiguration::userContentController): Deleted.
(API::PageConfiguration::visitedLinkStore): Deleted.
(API::PageConfiguration::websiteDataStore): Deleted.
(API::PageConfiguration::protectedWebsiteDataStore): Deleted.
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::Data::initializer):
* Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::WebsitePolicies):
(API::WebsitePolicies::copy const):
* Source/WebKit/UIProcess/API/APIWebsitePolicies.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setupPageConfiguration:]):
(validate): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration processPool]):
(-[WKWebViewConfiguration setProcessPool:]):
(-[WKWebViewConfiguration preferences]):
(-[WKWebViewConfiguration setPreferences:]):
(-[WKWebViewConfiguration userContentController]):
(-[WKWebViewConfiguration setUserContentController:]):
(-[WKWebViewConfiguration websiteDataStore]):
(-[WKWebViewConfiguration setWebsiteDataStore:]):
(-[WKWebViewConfiguration defaultWebpagePreferences]):
(-[WKWebViewConfiguration setDefaultWebpagePreferences:]):
(-[WKWebViewConfiguration _visitedLinkStore]):
(-[WKWebViewConfiguration _setVisitedLinkStore:]):
(-[WKWebViewConfiguration _websiteDataStoreIfExists]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences init]):
(): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h:
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
(WKWPE::m_backend):
* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
* Source/WebKit/UIProcess/Cocoa/WebPagePreferencesLockdownModeObserver.h: Copied from Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h.
* Source/WebKit/UIProcess/Cocoa/WebPagePreferencesLockdownModeObserver.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h.
(WebKit::WebPagePreferencesLockdownModeObserver::WebPagePreferencesLockdownModeObserver):
(WebKit::WebPagePreferencesLockdownModeObserver::~WebPagePreferencesLockdownModeObserver):
(WebKit::WebPagePreferencesLockdownModeObserver::willChangeLockdownMode):
(WebKit::WebPagePreferencesLockdownModeObserver::didChangeLockdownMode):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::m_browsingContextGroup):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* Source/WebKit/UIProcess/WebPageProxy.cpp.orig: Copied from Source/WebKit/UIProcess/WebPageProxy.cpp.
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createWebPage):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::predictedUserAgentForRequest const):
* Source/WebKit/UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
(TEST):

Canonical link: https://commits.webkit.org/276462@main

b9bb653

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-20T07:01:55Z

EWS run on previous version of this PR (hash d41d8ac)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		❌ 🛠 wpe-skia
⏳ 🛠 🧪 jsc	❌ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🛠 gtk
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	⏳ 🛠 tv-sim		❌ 🧪 api-gtk
	⏳ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-03-20T07:16:20Z

EWS run on previous version of this PR (hash 94efcd5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		❌ 🛠 wpe-skia
⏳ 🛠 🧪 jsc	❌ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🛠 gtk
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	⏳ 🛠 tv-sim		❌ 🧪 api-gtk
	⏳ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-03-20T07:30:16Z

EWS run on previous version of this PR (hash 80ea1d6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		❌ 🛠 wpe-skia
⏳ 🛠 🧪 jsc	❌ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	❌ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	⏳ 🛠 tv-sim		~~🧪 api-gtk~~
	⏳ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-03-20T07:39:40Z

EWS run on previous version of this PR (hash cb4cdbe)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		❌ 🛠 wpe-skia
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim		❌ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-20T19:42:19Z

EWS run on previous version of this PR (hash 94ce76b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	💥 🧪 wpe-wk2
✅ 🧪 webkitperl	💥 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 wpe-skia
	❌ 🧪 api-ios	💥 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	💥 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	~~🛠 watch~~
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-03-20T22:49:39Z

EWS run on previous version of this PR (hash 6ac194d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 tv-sim~~		✅ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-21T01:51:48Z

EWS run on previous version of this PR (hash 039ddc8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 tv-sim~~		⏳ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-21T03:32:07Z

EWS run on previous version of this PR (hash 9d12a61)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	~~🛠 tv-sim~~		⏳ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

cdumez

r=me with changes.

cdumez · 2024-03-21T03:39:38Z

Source/WebKit/UIProcess/API/APIPageConfiguration.h

+        static Ref<WebKit::WebPreferences> createWebPreferences();
+        static Ref<WebKit::VisitedLinkStore> createVisitedLinkStore();
+        static Ref<WebsitePolicies> createWebsitePolicies();
+        LazyInitializedRef<WebKit::BrowsingContextGroup, createBrowsingContextGroup> browsingContextGroup;


nit: Please add a blank line to separate member functions from data members.

cdumez · 2024-03-21T03:41:20Z

Source/WebKit/UIProcess/Cocoa/WebPagePreferencesLockdownModeObserver.h

+class WebPagePreferencesLockdownModeObserver final : public LockdownModeObserver {
+    WTF_MAKE_FAST_ALLOCATED;
+public:
+    WebPagePreferencesLockdownModeObserver(API::WebsitePolicies&);


cdumez · 2024-03-21T03:42:24Z

Source/WebKit/UIProcess/WebPageProxy.cpp.orig

@@ -0,0 +1,13814 @@
+/*
+ * Copyright (C) 2010-2023 Apple Inc. All rights reserved.


Please drop this file from the PR before landing. .orig

webkit-early-warning-system · 2024-03-21T04:56:23Z

EWS run on previous version of this PR (hash 46d363d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 wpe-skia
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	~~🛠 tv-sim~~		⏳ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-21T05:31:59Z

EWS run on current version of this PR (hash b9bb653)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

…ageConfiguration https://bugs.webkit.org/show_bug.cgi?id=271301 rdar://125067469 Reviewed by Chris Dumez. This is a step towards the API::PageConfiguration being made in WebPageProxy::createNewPage rather than UIClient::createNewPage. This new way of storing these objects is more robust against invalid use of WKWebViewConfiguration if nil is set as the value of non-nullable objects, so the validate step is no longer needed and the InvalidConfiguration API test needed some changes, but this should have no impact on legitimate use of the API. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::Data::createBrowsingContextGroup): (API::PageConfiguration::Data::createWebProcessPool): (API::PageConfiguration::Data::createWebUserContentControllerProxy): (API::PageConfiguration::Data::createWebPreferences): (API::PageConfiguration::Data::createVisitedLinkStore): (API::PageConfiguration::Data::createWebsitePolicies): (API::PageConfiguration::create): (API::PageConfiguration::browsingContextGroup const): (API::PageConfiguration::processPool const): (API::PageConfiguration::userContentController const): (API::PageConfiguration::preferences const): (API::PageConfiguration::pageToCloneSessionStorageFrom const): (API::PageConfiguration::setPageToCloneSessionStorageFrom): (API::PageConfiguration::visitedLinkStore const): (API::PageConfiguration::websiteDataStore const): (API::PageConfiguration::websiteDataStoreIfExists const): (API::PageConfiguration::protectedWebsiteDataStore const): (API::PageConfiguration::setWebsiteDataStore): (API::PageConfiguration::defaultWebsitePolicies const): (API::PageConfiguration::urlSchemeHandlerForURLScheme): (API::PageConfiguration::setURLSchemeHandlerForURLScheme): (API::PageConfiguration::lockdownModeEnabled const): (API::PageConfiguration::delaysWebProcessLaunchUntilFirstLoad const): (API::PageConfiguration::isLockdownModeExplicitlySet const): (API::PageConfiguration::preferencesForGPUProcess const): (API::PageConfiguration::preferencesForNetworkProcess const): (API::PageConfiguration::PageConfiguration): Deleted. (API::PageConfiguration::browsingContextGroup): Deleted. (API::PageConfiguration::processPool): Deleted. (API::PageConfiguration::userContentController): Deleted. (API::PageConfiguration::visitedLinkStore): Deleted. (API::PageConfiguration::websiteDataStore): Deleted. (API::PageConfiguration::protectedWebsiteDataStore): Deleted. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::Data::initializer): * Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::WebsitePolicies): (API::WebsitePolicies::copy const): * Source/WebKit/UIProcess/API/APIWebsitePolicies.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): (-[WKWebView _setupPageConfiguration:]): (validate): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration processPool]): (-[WKWebViewConfiguration setProcessPool:]): (-[WKWebViewConfiguration preferences]): (-[WKWebViewConfiguration setPreferences:]): (-[WKWebViewConfiguration userContentController]): (-[WKWebViewConfiguration setUserContentController:]): (-[WKWebViewConfiguration websiteDataStore]): (-[WKWebViewConfiguration setWebsiteDataStore:]): (-[WKWebViewConfiguration defaultWebpagePreferences]): (-[WKWebViewConfiguration setDefaultWebpagePreferences:]): (-[WKWebViewConfiguration _visitedLinkStore]): (-[WKWebViewConfiguration _setVisitedLinkStore:]): (-[WKWebViewConfiguration _websiteDataStoreIfExists]): * Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm: (-[WKWebpagePreferences init]): (): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h: * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseCreateWebPage): * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): * Source/WebKit/UIProcess/Cocoa/WebPagePreferencesLockdownModeObserver.h: Copied from Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h. * Source/WebKit/UIProcess/Cocoa/WebPagePreferencesLockdownModeObserver.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h. (WebKit::WebPagePreferencesLockdownModeObserver::WebPagePreferencesLockdownModeObserver): (WebKit::WebPagePreferencesLockdownModeObserver::~WebPagePreferencesLockdownModeObserver): (WebKit::WebPagePreferencesLockdownModeObserver::willChangeLockdownMode): (WebKit::WebPagePreferencesLockdownModeObserver::didChangeLockdownMode): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): (WebKit::m_browsingContextGroup): (WebKit::WebPageProxy::decidePolicyForNavigationAction): * Source/WebKit/UIProcess/WebPageProxy.cpp.orig: Copied from Source/WebKit/UIProcess/WebPageProxy.cpp. * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createWebPage): * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::predictedUserAgentForRequest const): * Source/WebKit/UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm: (TEST): Canonical link: https://commits.webkit.org/276462@main

webkit-commit-queue · 2024-03-21T14:57:10Z

Committed 276462@main (9b4ec97): https://commits.webkit.org/276462@main

Reviewed commits have been landed. Closing PR #26177 and removing active labels.

rkirsling · 2024-03-22T05:11:24Z

PlayStationWebView was not updated; fixed in #26299.

achristensen07 requested a review from cdumez as a code owner March 20, 2024 07:01

achristensen07 self-assigned this Mar 20, 2024

achristensen07 added the WebKit API For issues and bugs in the Web Kit public embedding APIs label Mar 20, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 20, 2024