[WTR][Skia] Add support for web contents pixel results #26179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgcampos
requested review from
a team,
alexgcastro,
nikolaszimmermann,
magomez and
zdobersek
as code owners
carlosgcampos
added
the
Tools / Tests
|
EWS run on current version of this PR (hash 239ccf0) |
alexgcastro
approved these changes
Mar 20, 2024
carlosgcampos
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=271239 Reviewed by Alejandro G. Castro. Add WKImageSkia with WKImageCreateSkImage() to be used from dumpPixelsAndCompareWithExpected(). * Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp: (WKImageCreateCairoSurface): (WKImageCreateFromCairoSurface): * Source/WebKit/Shared/API/c/cairo/WKImageCairo.h: * Source/WebKit/Shared/API/c/skia/WKImageSkia.cpp: Copied from Source/WebKit/Shared/API/c/cairo/WKImageCairo.h. (WKImageCreateSkImage): * Source/WebKit/Shared/API/c/skia/WKImageSkia.h: Copied from Source/WebKit/Shared/API/c/cairo/WKImageCairo.h. * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: * Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: * Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Canonical link: https://commits.webkit.org/276401@main
webkit-commit-queue
force-pushed
the
skia-printing-pixel-tests
branch
from
239ccf0
to
bcddb3e
Compare
|
Committed 276401@main (bcddb3e): https://commits.webkit.org/276401@main Reviewed commits have been landed. Closing PR #26179 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bcddb3e
239ccf0
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2