Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build WebKit process extensions for all SDK variants #26189

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Build WebKit process extensions for all SDK variants #26189

merged 1 commit into from
Mar 20, 2024

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Mar 20, 2024 •
edited by webkit-early-warning-system
Loading

@pvollan pvollan requested a review from emw-apple as a code owner March 20, 2024 14:37
@pvollan pvollan self-assigned this Mar 20, 2024
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 20, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 20, 2024 •
edited
Loading

EWS run on current version of this PR (hash cc9e522)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 💥 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 loading 🧪 api-mac loading-orange 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
loading 🛠 🧪 jsc loading 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv 💥 🧪 mac-AS-debug-wk2 💥 🧪 gtk-wk2
✅ 🛠 tv-sim loading-orange 🧪 api-gtk
loading 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan requested review from cdumez and szewai March 20, 2024 14:42
@pvollan
Copy link
Contributor Author

pvollan commented Mar 20, 2024

Thanks for reviewing!

@pvollan pvollan added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing merge-queue Applied to send a pull request to merge-queue labels Mar 20, 2024
@pvollan pvollan added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Mar 20, 2024
@pvollan
Build WebKit process extensions for all SDK variants
6a907ad 
https://bugs.webkit.org/show_bug.cgi?id=271315
rdar://125062966

Reviewed by Chris Dumez.

* Source/WebKit/Configurations/BaseExtension.xcconfig:

Canonical link: https://commits.webkit.org/276415@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Build-WebKit-process-extensions-for-all-SDK-variants branch from cc9e522 to 6a907ad Compare March 20, 2024 20:39
@webkit-commit-queue
Copy link
Collaborator

Committed 276415@main (6a907ad): https://commits.webkit.org/276415@main

Reviewed commits have been landed. Closing PR #26189 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6a907ad into WebKit:main Mar 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@bls1999 bls1999 bls1999 approved these changes

@emw-apple emw-apple Awaiting requested review from emw-apple emw-apple is a code owner

@szewai szewai Awaiting requested review from szewai

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @cdumez @bls1999