Add fallback impl for FileSystem createTemporaryDirectory #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the EWS failures are unrelated (haven't looked at the wincairo failure yet), is this ready for review? |
cdumez
reviewed
Jul 22, 2022
cdumez
approved these changes
Jul 23, 2022
Source/WTF/wtf/FileSystem.cpp
Outdated
| newTempDirTemplate += "XXXXXXXX"; | ||
|
|
||
| Vector<char> newTempDir(newTempDirTemplate.c_str(), newTempDirTemplate.size()); | ||
|
|
There was a problem hiding this comment.
nit: I don't think we need this new line.
There was a problem hiding this comment.
I've made the changes and I think it's ready
|
This change contains multiple commits which are not squashed together, blocking PR #2626. Please squash the commits to land. |
webkit-commit-queue
added
merging-blocked
|
We can only have 1 commit per PR. You currently have 2 commits so our infrastructure is unable to merge the PR. |
caitp
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=232499 Reviewed by Chris Dumez. * Source/WTF/wtf/FileSystem.cpp: (WTF::FileSystemImpl::createTemporaryDirectory): * Source/WTF/wtf/FileSystem.h: Canonical link: https://commits.webkit.org/252799@main
webkit-early-warning-system
force-pushed
the
ctd_bug
branch
from
39dc894
to
00e1e0d
Compare
|
Committed 252799@main (00e1e0d): https://commits.webkit.org/252799@main Reviewed commits have been landed. Closing PR #2626 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
00e1e0d