-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSC] Emit dyld tracepoint to tell system profiler about JIT code region #26271
[JSC] Emit dyld tracepoint to tell system profiler about JIT code region #26271
Conversation
EWS run on previous version of this PR (hash 41424ae) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
41424ae
to
564f537
Compare
EWS run on current version of this PR (hash 564f537) |
https://bugs.webkit.org/show_bug.cgi?id=271419 rdar://125196249 Reviewed by Justin Michaud. This patch emits fake dyld tracepoint which tells our system profiler (see SystemTracing.h) about JIT code region. We need to assign good UUID to this JIT code region. And since this is JIT code, each process has different JIT code. Thus, we create v5 UUID from process ID and namespace UUID and attach it to JIT code region. * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::initializeJITPageReservation): * Source/WTF/wtf/ByteOrder.h: (WTF::bswap64): * Source/WTF/wtf/UUID.cpp: (WTF::UUID::createVersion5): * Source/WTF/wtf/UUID.h: Canonical link: https://commits.webkit.org/276524@main
564f537
to
2645a1e
Compare
Committed 276524@main (2645a1e): https://commits.webkit.org/276524@main Reviewed commits have been landed. Closing PR #26271 and removing active labels. |
Unfortunately, the names |
2645a1e
564f537
π§ͺ wpe-wk2π§ͺ api-macπ§ͺ ios-wk2-wptπ π§ͺ jscπ π§ͺ jsc-arm64π§ͺ gtk-wk2π tv-simπ watch