Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Fatal Exceptions Entitlement #26345

Conversation

justinmichaud
Copy link
Contributor

@justinmichaud justinmichaud commented Mar 22, 2024

@justinmichaud justinmichaud requested a review from a team as a code owner March 22, 2024 22:39
@justinmichaud justinmichaud self-assigned this Mar 22, 2024
@justinmichaud justinmichaud added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Mar 22, 2024
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@justinmichaud justinmichaud added the merge-queue Applied to send a pull request to merge-queue label Mar 23, 2024
https://bugs.webkit.org/show_bug.cgi?id=271496
rdar://125261792

Reviewed by Mark Lam.

Adopt Fatal Exceptions Entitlement. This entitlement should be safe to adopt
on all Apple platforms.

* Source/JavaScriptCore/Scripts/process-entitlements.sh:
* Source/JavaScriptCore/entitlements.plist:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentProcessExtension.entitlements:

Canonical link: https://commits.webkit.org/276590@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adopt-Fatal-Exceptions-Entitlement branch from 5eaa521 to 28e1e82 Compare March 23, 2024 16:38
@webkit-commit-queue
Copy link
Collaborator

Committed 276590@main (28e1e82): https://commits.webkit.org/276590@main

Reviewed commits have been landed. Closing PR #26345 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 28e1e82 into WebKit:main Mar 23, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 23, 2024
@justinmichaud justinmichaud deleted the eng/Adopt-Fatal-Exceptions-Entitlement branch April 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
4 participants