-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebXR should not work from an iFrame unless it is allowed to use the xr-spatial-tracking permissions policy #26376
WebXR should not work from an iFrame unless it is allowed to use the xr-spatial-tracking permissions policy #26376
Conversation
EWS run on previous version of this PR (hash f23fd7d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-reviewer π from me. Nice one solving for the script duplication!
f23fd7d
to
224554e
Compare
EWS run on previous version of this PR (hash 224554e) |
224554e
to
2559ec2
Compare
EWS run on current version of this PR (hash 2559ec2) |
β¦xr-spatial-tracking permissions policy https://bugs.webkit.org/show_bug.cgi?id=271363 rdar://122963817 Reviewed by Mike Wyrzykowski. Follow the latest WebXR spec and check whether 'xr-spatial-tracking' is enabled for the requesting document's origin in WebGLRenderingContextBase::makeXRCompatible and WebXRSystem::resolveRequestedFeatures. Added layout tests to verify 'xr-spatial-tracking' permissions policy is checked properly for xr.isSessionSupported, xr.requestSession, and WebGLRenderingContextBase::makeXRCompatible. Set up symbolic links to the webxr related scripts from http/wpt/webxr folder so the pages embedded in the iframes can reference them. * LayoutTests/http/tests/webxr/resources/resources/test-only-api.js: Added. * LayoutTests/http/tests/webxr/resources/resources/webxr_test_constants_single_view.js: Added. * LayoutTests/http/tests/webxr/resources/resources/webxr_util.js: Added. * LayoutTests/http/tests/webxr/resources/webxr-issessionsupported-test.html: Added. * LayoutTests/http/tests/webxr/resources/webxr-makexrcompatible-test.html: Added. * LayoutTests/http/tests/webxr/resources/webxr-requestsession-test.html: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-issessionsupported-allowed-by-feature-policy-expected.txt: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-issessionsupported-allowed-by-feature-policy.html: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-issessionsupported-denied-by-insufficient-feature-policy-expected.txt: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-issessionsupported-denied-by-insufficient-feature-policy.html: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-makexrcompatible-allowed-by-feature-policy-expected.txt: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-makexrcompatible-allowed-by-feature-policy.html: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-makexrcompatible-denied-by-insufficient-feature-policy-expected.txt: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-makexrcompatible-denied-by-insufficient-feature-policy.html: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-requestsession-allowed-by-feature-policy-expected.txt: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-requestsession-allowed-by-feature-policy.html: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-requestsession-denied-by-insufficient-feature-policy-expected.txt: Added. * LayoutTests/http/tests/webxr/webxr-third-party-iframe-requestsession-denied-by-insufficient-feature-policy.html: Added. * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-gpup/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Skip http/tests/webxr tests in the same places where we've skipped other webxr layout tests. * LayoutTests/platform/wpe/TestExpectations: Filed a new bug on a crash found when calling WebXRSession destructor. * LayoutTests/platform/wincairo/TestExpectations: Skip http/tests/webxr tests in the same places where we've skipped other webxr layout tests. * Source/WebCore/Modules/webxr/WebXRSystem.cpp: (WebCore::WebXRSystem::isFeaturePermitted const): (WebCore::WebXRSystem::resolveRequestedFeatures const): * Source/WebCore/Modules/webxr/WebXRSystem.h: * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::makeXRCompatible): Canonical link: https://commits.webkit.org/277301@main
2559ec2
to
7b007a8
Compare
Committed 277301@main (7b007a8): https://commits.webkit.org/277301@main Reviewed commits have been landed. Closing PR #26376 and removing active labels. |
7b007a8
2559ec2