-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement URL.parse() #26403
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
annevk:eng/Implement-URL-parse
Mar 25, 2024
Merged
Implement URL.parse() #26403
webkit-commit-queue
merged 1 commit into
WebKit:main
from
annevk:eng/Implement-URL-parse
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
added
the
DOM
For bugs specific to XML/HTML DOM elements (including parsing).
label
Mar 25, 2024
EWS run on previous version of this PR (hash b8cc2a7) |
achristensen07
approved these changes
Mar 25, 2024
annevk
force-pushed
the
eng/Implement-URL-parse
branch
from
March 25, 2024 17:17
b8cc2a7
to
4d52cd6
Compare
EWS run on current version of this PR (hash 4d52cd6) |
annevk
added
safe-merge-queue
Applied to automatically send a pull-request to merge-queue after passing EWS checks
merge-queue
Applied to send a pull request to merge-queue
and removed
safe-merge-queue
Applied to automatically send a pull-request to merge-queue after passing EWS checks
labels
Mar 25, 2024
https://bugs.webkit.org/show_bug.cgi?id=271636 Reviewed by Alex Christensen. This was standardized in whatwg/url#825 and test coverage was added here: web-platform-tests/wpt#45248 As a drive-by fix we remove m_baseURL from DOMURL as it does not need it. * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.html: Added. * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.js: Added. (forEach): (test): * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.worker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/url/w3c-import.log: * Source/WebCore/html/DOMURL.cpp: (WebCore::DOMURL::DOMURL): (WebCore::DOMURL::create): (WebCore::parseInternal): (WebCore::DOMURL::parse): (WebCore::DOMURL::canParse): * Source/WebCore/html/DOMURL.h: * Source/WebCore/html/DOMURL.idl: Canonical link: https://commits.webkit.org/276656@main
webkit-commit-queue
force-pushed
the
eng/Implement-URL-parse
branch
from
March 25, 2024 22:20
4d52cd6
to
e1614bd
Compare
Committed 276656@main (e1614bd): https://commits.webkit.org/276656@main Reviewed commits have been landed. Closing PR #26403 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e1614bd
4d52cd6
π watch