-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::span more in Source/WebKit/WebProcess #26499
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
cdumez:271746_WebProcess_span
Mar 27, 2024
Merged
Use std::span more in Source/WebKit/WebProcess #26499
webkit-commit-queue
merged 1 commit into
WebKit:main
from
cdumez:271746_WebProcess_span
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on current version of this PR (hash fc56759) |
cdumez
requested review from
youennf,
rniwa,
geoffreygaren,
darinadler and
brentfulgham
March 27, 2024 15:31
brentfulgham
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! r=me.
cdumez
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Mar 27, 2024
https://bugs.webkit.org/show_bug.cgi?id=271746 Reviewed by Brent Fulgham. * Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp: (WebKit::RemoteVideoCodecFactory::createDecoder): (WebKit::RemoteVideoDecoder::decode): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: (WebKit::decodeVideoFrame): (WebKit::LibWebRTCCodecs::setDecoderFormatDescription): (WebKit::sendFrameToDecode): (WebKit::LibWebRTCCodecs::decodeFrame): (WebKit::LibWebRTCCodecs::setDecoderConnection): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h: * Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp: (WebKit::SharedVideoFrameReader::readBufferFromSharedMemory): * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp: (WebKit::LibWebRTCNetwork::signalReadPacket): * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp: (WebKit::LibWebRTCSocket::signalReadPacket): * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm: (WebKit::ByteRangeRequest::completeWithBytes): (WebKit::ByteRangeRequest::completeWithAccumulatedData): (WebKit::ByteRangeRequest::completeUnconditionally): (WebKit::PDFIncrementalLoader::dataPtrForRange const): (WebKit::PDFIncrementalLoader::requestCompleteIfPossible): (WebKit::PDFIncrementalLoader::dataProviderGetBytesAtPosition): (WebKit::PDFIncrementalLoader::dataProviderGetByteRanges): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::dataPtrForRange const): * Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp: (WebKit::IPCTestingAPI::arrayBufferSpanFromValueRef): (WebKit::IPCTestingAPI::JSSharedMemory::writeBytes): (WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::writeBytes): (WebKit::IPCTestingAPI::encodeTypedArray): (WebKit::IPCTestingAPI::arrayBufferDataFromValueRef): Deleted. Canonical link: https://commits.webkit.org/276741@main
webkit-commit-queue
force-pushed
the
271746_WebProcess_span
branch
from
March 27, 2024 18:10
fc56759
to
285d4aa
Compare
Committed 276741@main (285d4aa): https://commits.webkit.org/276741@main Reviewed commits have been landed. Closing PR #26499 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
285d4aa
fc56759