Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK] Video alpha channel doesn't work #26598

Conversation

cadubentzen
Copy link
Contributor

@cadubentzen cadubentzen commented Mar 29, 2024

aff02c3

[GTK] Video alpha channel doesn't work
https://bugs.webkit.org/show_bug.cgi?id=233955

Reviewed by Miguel Gomez.

Set the ShouldBlend and ShouldPremultiply flags for the texture mapper when
pushing dma-buf video frames with alpha channel. This replicates what is done
for the GSTREAMER_GL code path in 238313@main.

Covered by media/video-with-alpha.html and manually tested with
https://zipdox.net/alphawebm/.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):

Canonical link: https://commits.webkit.org/276936@main

965c80e

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
⏳ πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@cadubentzen cadubentzen force-pushed the eng/GTK-Video-alpha-channel-doesnt-work branch from 669872c to 965c80e Compare March 29, 2024 01:38
@cadubentzen cadubentzen marked this pull request as ready for review March 29, 2024 15:49
@cadubentzen cadubentzen requested a review from philn as a code owner March 29, 2024 15:49
@magomez magomez added the merge-queue Applied to send a pull request to merge-queue label Apr 2, 2024
https://bugs.webkit.org/show_bug.cgi?id=233955

Reviewed by Miguel Gomez.

Set the ShouldBlend and ShouldPremultiply flags for the texture mapper when
pushing dma-buf video frames with alpha channel. This replicates what is done
for the GSTREAMER_GL code path in 238313@main.

Covered by media/video-with-alpha.html and manually tested with
https://zipdox.net/alphawebm/.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):

Canonical link: https://commits.webkit.org/276936@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GTK-Video-alpha-channel-doesnt-work branch from 965c80e to aff02c3 Compare April 2, 2024 16:13
@webkit-commit-queue
Copy link
Collaborator

Committed 276936@main (aff02c3): https://commits.webkit.org/276936@main

Reviewed commits have been landed. Closing PR #26598 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit aff02c3 into WebKit:main Apr 2, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 2, 2024
@cadubentzen cadubentzen deleted the eng/GTK-Video-alpha-channel-doesnt-work branch April 2, 2024 16:15
@philn philn added the GLib Suggested Backport Suggest this merge request be backported to current WPE/GTK stable branch label Apr 8, 2024
@carlosgcampos carlosgcampos removed the GLib Suggested Backport Suggest this merge request be backported to current WPE/GTK stable branch label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants