Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple tests crash with WebCore::ResourceUsageThread::platformCollectCPUData #26646

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Multiple tests crash with WebCore::ResourceUsageThread::platformCollectCPUData #26646

merged 1 commit into from
Mar 30, 2024

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Mar 30, 2024 •
edited by webkit-early-warning-system
Loading

358e75b

Multiple tests crash with WebCore::ResourceUsageThread::platformCollectCPUData
https://bugs.webkit.org/show_bug.cgi?id=271935
rdar://125471151

Reviewed by Sihui Liu.

The syscall thread_info should be included in the kernel-mig-routines-blocked-in-lockdown-mode define,
instead of the kernel-mig-routines-downlevels-blocked-in-lockdown-mode define, because it is not only
required for downlevels.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/276857@main

410abf7

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan self-assigned this Mar 30, 2024
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 30, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 30, 2024 •
edited
Loading

EWS run on current version of this PR (hash 410abf7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan
Copy link
Contributor Author

pvollan commented Mar 30, 2024

Thanks for reviewing!

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 30, 2024
@pvollan
Multiple tests crash with WebCore::ResourceUsageThread::platformColle…
358e75b 
…ctCPUData

https://bugs.webkit.org/show_bug.cgi?id=271935
rdar://125471151

Reviewed by Sihui Liu.

The syscall thread_info should be included in the kernel-mig-routines-blocked-in-lockdown-mode define,
instead of the kernel-mig-routines-downlevels-blocked-in-lockdown-mode define, because it is not only
required for downlevels.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/276857@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Multiple-tests-crash-with-WebCoreResourceUsageThreadplatformCollectCPUData branch from 410abf7 to 358e75b Compare March 30, 2024 18:31
@webkit-commit-queue webkit-commit-queue merged commit 358e75b into WebKit:main Mar 30, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 276857@main (358e75b): https://commits.webkit.org/276857@main

Reviewed commits have been landed. Closing PR #26646 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szewai szewai szewai approved these changes

@brentfulgham brentfulgham Awaiting requested review from brentfulgham brentfulgham is a code owner

@cdumez cdumez Awaiting requested review from cdumez

@kmiller68 kmiller68 Awaiting requested review from kmiller68

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @szewai