Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION (276827@main): When drawing a pattern, get the oriented image frame only if the orientation is not TopLeft #26688

Conversation

shallawa
Copy link
Contributor

@shallawa shallawa commented Apr 1, 2024

@shallawa shallawa self-assigned this Apr 1, 2024
@shallawa shallawa added the Images For bugs in image handling. label Apr 1, 2024
@shallawa shallawa requested a review from heycam April 1, 2024 19:32
@shallawa shallawa added the merge-queue Applied to send a pull request to merge-queue label Apr 1, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-276827main-When-drawing-a-pattern-get-the-oriented-image-frame-only-if-the-orientation-is-not-TopLeft branch from d17c342 to 5378553 Compare April 1, 2024 21:33
…age frame only if the orientation is not TopLeft

https://bugs.webkit.org/show_bug.cgi?id=271977
rdar://125731142

Reviewed by Mike Wyrzykowski.

If the passed orientation is FromImage, resolve the current orientation before
checking its value to the oriented ImageFrame.

* Source/WebCore/platform/graphics/BitmapImageSource.cpp:
(WebCore::BitmapImageSource::preTransformedNativeImageAtIndex):

Canonical link: https://commits.webkit.org/276902@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-276827main-When-drawing-a-pattern-get-the-oriented-image-frame-only-if-the-orientation-is-not-TopLeft branch from 5378553 to 34d1f9a Compare April 1, 2024 21:36
@webkit-commit-queue
Copy link
Collaborator

Committed 276902@main (34d1f9a): https://commits.webkit.org/276902@main

Reviewed commits have been landed. Closing PR #26688 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 34d1f9a into WebKit:main Apr 1, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 1, 2024
@shallawa shallawa deleted the eng/REGRESSION-276827main-When-drawing-a-pattern-get-the-oriented-image-frame-only-if-the-orientation-is-not-TopLeft branch May 1, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images For bugs in image handling.
Projects
None yet
4 participants