Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS 15.4] Fix embedded device build #269

Merged
merged 0 commits into from
Apr 8, 2022
Merged

[iOS 15.4] Fix embedded device build #269

merged 0 commits into from
Apr 8, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Apr 8, 2022 •
edited

f4b38e9

[iOS 15.4] Fix embedded device build
https://bugs.webkit.org/show_bug.cgi?id=239012
<rdar://problem/91495761 >

Reviewed by Ryan Haddad.

* Source/ThirdParty/ANGLE/Configurations/Base.xcconfig: Allow AdHoc codesigning.
* Source/WebKit/Configurations/Base.xcconfig: Ditto.

Canonical link: https://commits.webkit.org/249449@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Apr 8, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Apr 8, 2022
emw-apple
emw-apple previously approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@emw-apple emw-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why it's these two frameworks that need the AD_HOC_CODE_SIGNING_ALLOWED. JSC, WebKitTestRunner, DumpRenderTree, and ImageDiff, already have it. Maybe it's related to being a dylib with public headers?

Regardless, lgtm.

@emw-apple emw-apple dismissed their stale review April 8, 2022 19:35

not a WebKit reviewer

ryanhaddad
ryanhaddad approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@ryanhaddad ryanhaddad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on Slack discussion about this approach.

@JonWBedard
Copy link
Member Author

Merge-Queue is a bit slow today (and Unsafe-Merge-Queue isn't landed yet, which would be the solution in the future), landing manually to get our bots green

@JonWBedard JonWBedard merged commit f4b38e9 into WebKit:main Apr 8, 2022
@JonWBedard JonWBedard force-pushed the eng/iOS-15-4-Fix-embedded-device-build branch from 16e6318 to f4b38e9 Compare April 8, 2022 19:57
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/249449@main (f4b38e9)!

@JonWBedard JonWBedard deleted the eng/iOS-15-4-Fix-embedded-device-build branch April 8, 2022 19:58
@turbomaster95 turbomaster95 mentioned this pull request May 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhaddad ryanhaddad ryanhaddad approved these changes

@emw-apple emw-apple emw-apple left review comments

@aproskuryakov aproskuryakov Awaiting requested review from aproskuryakov

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@JonWBedard @ryanhaddad @emw-apple