[iOS 16] 'Insert text from camera' action should not appear in the edit menu when a range is selected #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whsieh
added
Platform
dcrousso
approved these changes
Jul 25, 2022
|
Thanks for the review! |
…it menu when a range is selected https://bugs.webkit.org/show_bug.cgi?id=243171 Reviewed by Devin Rousso. This is another platform behavior (similar to the one fixed in `252764@main`) that broke due to the new edit menu in iOS 16. The "Insert from camera" action (which shows up as a Live Text button in the edit menu) was intended to only show up when the selection is collapsed and editable; however, WebKit diverges from this platform behavior, since our logic for special-casing the edit menu is based around checking whether the `sender` in `canPerformActionForWebView:withSender:` is a `UIMenuController`, which is not the case when the iOS 16+ edit menu is enabled. To fix this, check the newly introduced `_isPreparingEditMenu` flag instead. Changes tested by augmenting an existing API test: `WebKit.CaptureTextFromCamera` * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView canPerformActionForWebView:withSender:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm: Canonical link: https://commits.webkit.org/252805@main
webkit-early-warning-system
force-pushed
the
eng/243171
branch
from
8d75448
to
c106e6e
Compare
|
Committed 252805@main (c106e6e): https://commits.webkit.org/252805@main Reviewed commits have been landed. Closing PR #2708 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c106e6e