Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer][WebCodecs] AV1 (with dav1d) decoding fixes #27230

Merged
merged 1 commit into from Apr 15, 2024

Conversation

philn
Copy link
Member

@philn philn commented Apr 14, 2024

f3b3ddc

[GStreamer][WebCodecs] AV1 (with dav1d) decoding fixes
https://bugs.webkit.org/show_bug.cgi?id=272642

Reviewed by Xabier Rodriguez-Calvar.

The decoder tests were failing mostly due to incomplete colorimetry handling in dav1ddec, which was
fixed upstream. The low-latency decoding test was failing because we were not configuring the
decoder to internally use a single thread. The parser was discarding corrupted frames, leading to
another test failure, so it was removed from the harnessed pipeline (the decoder rejects corrupted
frames already).

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_av1-expected.txt: Removed.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_av1-expected.txt: Removed.
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::configureVideoDecoderForHarnessing):
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp:
(WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder):

Canonical link: https://commits.webkit.org/277488@main

7d5a0d1

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@philn philn self-assigned this Apr 14, 2024
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Apr 14, 2024
@philn philn requested a review from calvaris April 14, 2024 10:08
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Apr 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=272642

Reviewed by Xabier Rodriguez-Calvar.

The decoder tests were failing mostly due to incomplete colorimetry handling in dav1ddec, which was
fixed upstream. The low-latency decoding test was failing because we were not configuring the
decoder to internally use a single thread. The parser was discarding corrupted frames, leading to
another test failure, so it was removed from the harnessed pipeline (the decoder rejects corrupted
frames already).

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_av1-expected.txt: Removed.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_av1-expected.txt: Removed.
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::configureVideoDecoderForHarnessing):
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp:
(WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder):

Canonical link: https://commits.webkit.org/277488@main
@webkit-commit-queue
Copy link
Collaborator

Committed 277488@main (f3b3ddc): https://commits.webkit.org/277488@main

Reviewed commits have been landed. Closing PR #27230 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f3b3ddc into WebKit:main Apr 15, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 15, 2024
@philn philn deleted the eng/272642 branch April 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants