Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing array.h include in generated PlugInsResourcesData #27325

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Missing array.h include in generated PlugInsResourcesData #27325

merged 1 commit into from
Apr 16, 2024

Conversation

philn
Copy link
Member

@philn philn commented Apr 16, 2024 •
edited by webkit-early-warning-system

18a90f0

Missing array.h include in generated PlugInsResourcesData
https://bugs.webkit.org/show_bug.cgi?id=272744

Reviewed by Michael Catanzaro.

* Source/WebCore/css/make-css-file-arrays.pl: Add includes necessary for std::array usage.

Canonical link: https://commits.webkit.org/277575@main

33b38f9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Apr 16, 2024
@philn philn added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Apr 16, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 33b38f9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn requested a review from a team April 16, 2024 13:23
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Apr 16, 2024
@philn
Missing array.h include in generated PlugInsResourcesData
18a90f0 
https://bugs.webkit.org/show_bug.cgi?id=272744

Reviewed by Michael Catanzaro.

* Source/WebCore/css/make-css-file-arrays.pl: Add includes necessary for std::array usage.

Canonical link: https://commits.webkit.org/277575@main
@webkit-commit-queue
Copy link
Collaborator

Committed 277575@main (18a90f0): https://commits.webkit.org/277575@main

Reviewed commits have been landed. Closing PR #27325 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 18a90f0 into WebKit:main Apr 16, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 16, 2024
@philn philn deleted the eng/272744 branch April 17, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

Assignees

@philn philn

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
4 participants
@philn @webkit-early-warning-system @webkit-commit-queue @mcatanzaro