[git-webkit] Add screen-reader friendly review wizard (Part 1) #27628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash eac1a27) |
webkit-ews-buildbot
added
the
merging-blocked
JonWBedard
removed
the
merging-blocked
JonWBedard
force-pushed
the
eng/add-screen-reader-friendly-review-wizard
branch
from
eac1a27
to
ba0312b
Compare
|
EWS run on previous version of this PR (hash ba0312b) |
JonWBedard
changed the title
webkit-ews-buildbot
added
the
merging-blocked
JonWBedard
removed
the
merging-blocked
JonWBedard
changed the title
JonWBedard
force-pushed
the
eng/add-screen-reader-friendly-review-wizard
branch
from
ba0312b
to
364d251
Compare
JonWBedard
changed the title
|
EWS run on previous version of this PR (hash 364d251) |
webkit-ews-buildbot
added
the
merging-blocked
JonWBedard
removed
the
merging-blocked
JonWBedard
force-pushed
the
eng/add-screen-reader-friendly-review-wizard
branch
from
364d251
to
ed3950c
Compare
|
@emw-apple, there is a "part 2" which is ready as well, I will upload that tomorrow. |
|
EWS run on previous version of this PR (hash ed3950c) |
webkit-ews-buildbot
added
the
merging-blocked
JonWBedard
removed
the
merging-blocked
JonWBedard
force-pushed
the
eng/add-screen-reader-friendly-review-wizard
branch
from
ed3950c
to
097948b
Compare
|
EWS run on previous version of this PR (hash 097948b) |
emw-apple
approved these changes
May 23, 2024
| help='Specify remote to search for pull request from.', | ||
| ) | ||
| parser.add_argument( | ||
| '--dry-run', '-d', '--no-dry-run', |
There was a problem hiding this comment.
nit: "-n" is typically the single-character dry run argument.
| if from_config: | ||
| return from_config.split(' ') | ||
|
|
||
| from whichcraft import which |
There was a problem hiding this comment.
Why not use shutil.which? Surely we don't need to support python < 3.3 here.
There was a problem hiding this comment.
Not any more! When this PR was first written, we still needed Python 2 support here.
| return from_config.split(' ') | ||
|
|
||
| from whichcraft import which | ||
| return [which('vi')] |
There was a problem hiding this comment.
nit: On some linux distributions (iirc, anything Debian-based), vi will be the ancient POSIX vi program, not vim. So you might want to default to vim?
JonWBedard
force-pushed
the
eng/add-screen-reader-friendly-review-wizard
branch
from
097948b
to
f7983bb
Compare
|
EWS run on current version of this PR (hash f7983bb) |
JonWBedard
added
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=261242 rdar://115083100 Reviewed by Elliott Williams. Add a read-only text-based PR review tool to git-webkit. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: (Git.__init__): Add an "editor" argument which allows a caller to define an editor callback which is invoke when the mock commit message editor is called during the testing context. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py: Add Review program. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/review.py: Added. (Review.parser): Define arguments for the sub-program. (Review.editor): Use a repository object to determine the user's prefered editor, matching the editor used to edit commit messages. (Review.args_for_url): Extract PR number and repository object from a URL, allowing a user to specify a PR URL instead of a number and remote. (Review.invoke_wizard): Generate a local file representing a PR, which includes the PR diff and comments made against that diff. Open that local file in the user's prefered editor. (Review.main): Extract a remote pull-request from the provided arguments and invoke the local wizard with the pull-request details. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/review_unittest.py: Added. (TestReview): (TestReview.editor_callback): (TestReview.editor_callback.callback): (TestReview.test_bitbucket): (TestReview.test_bitbucket_diff): (TestReview.test_github): (TestReview.test_github_files): (TestReview.test_invalid_pr_url): (TestReview.test_pr_argument): (TestReview.test_editor_no_repo): (TestReview.test_editor_repo): (TestReview.test_invoke_wizard): (TestReview.test_help): (TestReview.test_bitbucket_read): (TestReview.test_github_read): (TestReview.test_bitbucket_read_comments): (TestReview.test_github_read_comments): Canonical link: https://commits.webkit.org/279244@main
webkit-commit-queue
force-pushed
the
eng/add-screen-reader-friendly-review-wizard
branch
from
f7983bb
to
26ef083
Compare
|
Committed 279244@main (26ef083): https://commits.webkit.org/279244@main Reviewed commits have been landed. Closing PR #27628 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
26ef083
f7983bb
🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 wincairo-tests🧪 ios-wk2🧪 api-wpe🧪 ios-wk2-wpt🧪 api-ios🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 api-gtk🛠 watch🛠 watch-sim