Null check IOSurfaceRef when creating WebCore::IOSurface from IOSurfaceRef #2767
Conversation
tuankiet65
added
WebCore Misc.
| @@ -213,6 +216,8 @@ | |||
| : m_colorSpace(colorSpace) | |||
| , m_surface(surface) | |||
| { | |||
| ASSERT(surface); | |||
There was a problem hiding this comment.
Is it possible for this assertion to be hit because surface null checked before it can reach this code? If so, an assertion might make more sense in the ::createFromSurface method so it has the chance to be hit while in a debug build.
There was a problem hiding this comment.
I was going to say "defense mechanism hey!" but this is a private constructor already. I can remove this then. About asserting vs. returning nullptr, I like the latter more because createFromImage below does that.
There was a problem hiding this comment.
Yup, it looks like DisplayBufferDisplayDelegate expects createFromSurface to potentially return a nullptr so it makes sense.
There was a problem hiding this comment.
It might make sense to assert at the end of DisplayBufferDisplayDelegate::setDisplayBuffer in order to catch some simple errors, but I am not familiar with this code enough.
tuankiet65
force-pushed
the
eng/Null-check-IOSurfaceRef-when-creating-WebCoreIOSurface-from-IOSurfaceRef
branch
from
bb81ec1
to
ed35a92
Compare
|
Before landing, please add a more substantial commit message. What’s the reasoning for putting this check inside the function rather than at the call sites? |
tuankiet65
force-pushed
the
eng/Null-check-IOSurfaceRef-when-creating-WebCoreIOSurface-from-IOSurfaceRef
branch
from
ed35a92
to
a2a2b18
Compare
…ceRef https://bugs.webkit.org/show_bug.cgi?id=243241 Reviewed by NOBODY (OOPS!). When creating a WebCore::IOSurface from an IOSurfaceRef, WebCore::IOSurface expects the IOSurfaceRef to be non-null, so it can pull out the dimension and allocation size of the IOSurfaceRef. * Source/WebCore/platform/graphics/cocoa/IOSurface.mm: (WebCore::IOSurface::createFromSurface):
tuankiet65
force-pushed
the
eng/Null-check-IOSurfaceRef-when-creating-WebCoreIOSurface-from-IOSurfaceRef
branch
from
a2a2b18
to
a8fb293
Compare
|
Superseded by #5785. |
a8fb293