[GTK][WPE] Don't allow depth test and stencil clipping if packed depth stencil is not supported #27682

magomez · 2024-04-24T10:53:24Z

`ed28635`

[GTK][WPE] Don't allow depth test and stencil clipping if packed depth stencil is not supported
https://bugs.webkit.org/show_bug.cgi?id=273177

Reviewed by Carlos Garcia Campos.

Use a packed depth stencil format when available, which allows depth testing
and stencil clipping at the same time. If packed depth stencil is not
supported, use separate buffers for depth and stencil. In the latter case,
if both buffers are requested at the same time, the stencil buffer won't
be created.

* Source/WebCore/platform/graphics/egl/GLContext.cpp:
(WebCore::GLContext::glExtensions const):
* Source/WebCore/platform/graphics/egl/GLContext.h:
* Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp:
(WebCore::depthBufferFormat):
(WebCore::BitmapTexture::initializeStencil):
(WebCore::BitmapTexture::initializeDepthBuffer):
(WebCore::BitmapTexture::~BitmapTexture):
* Source/WebCore/platform/graphics/texmap/BitmapTexture.h:

Canonical link: https://commits.webkit.org/278159@main

a1b1510

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-04-24T10:53:31Z

EWS run on previous version of this PR (hash 93c2dd9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-04-24T12:15:23Z

EWS run on previous version of this PR (hash 7cbe359)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

fujii · 2024-04-24T21:11:51Z

Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp

 namespace WebCore {

+GLenum depthBufferFormat()
+{
+    static std::once_flag onceFlag;


TextureMapper is thread agnostic. Clients have to call all TextureMapper API from a single thread.
I think TextureMapper doesn't need thread synchronization.

Yes, I know that TextureMapper is only used from the compositor thread. But I'm using std::call_once to ensure that the initialization of the depth buffer format happens only once. I could use a boolean flag to check whether the value is initialized or not, but std::call_once seems to be commonly used for that.

I don't think it's worth calling this only once, since both the extension and the version are cached.

fujii · 2024-04-24T21:14:10Z

Do you know which layout test case covers this change?

magomez · 2024-04-25T10:17:20Z

Do you know which layout test case covers this change?

I'm trying to create a test for it, but it's tricky.

magomez · 2024-04-29T12:06:35Z

Do you know which layout test case covers this change?

Creating a simple testcase to reproduce this is being complicated and I can't be stuck with this. The problem is reproducible in the page https://stv.vtmgo.be/vtmgo/prerelease/eos/index.html#/main/storefront?type=main . The size of the rendering area (not the window, as the window decorations reduce the size of the area) must be 1280x720 for it to happen, otherwise a scaling will be applied and then it won't reproduce.

There's a trailer button on the middle right part of the screen with a spinner animation. That's the one causing the problem. The main element of the page has position:fixed, which forces the creation of a stacking context and the rendering of almost all the page happens to a BitmapTexture with a depth buffer. Then the spinner image tries to do an stencil clip, adding the stencil buffer to the BitmapTexture, and this breaks the rendering of the page (at least when using mesa).

webkit-early-warning-system · 2024-04-29T14:56:50Z

EWS run on current version of this PR (hash a1b1510)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

…h stencil is not supported https://bugs.webkit.org/show_bug.cgi?id=273177 Reviewed by Carlos Garcia Campos. Use a packed depth stencil format when available, which allows depth testing and stencil clipping at the same time. If packed depth stencil is not supported, use separate buffers for depth and stencil. In the latter case, if both buffers are requested at the same time, the stencil buffer won't be created. * Source/WebCore/platform/graphics/egl/GLContext.cpp: (WebCore::GLContext::glExtensions const): * Source/WebCore/platform/graphics/egl/GLContext.h: * Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp: (WebCore::depthBufferFormat): (WebCore::BitmapTexture::initializeStencil): (WebCore::BitmapTexture::initializeDepthBuffer): (WebCore::BitmapTexture::~BitmapTexture): * Source/WebCore/platform/graphics/texmap/BitmapTexture.h: Canonical link: https://commits.webkit.org/278159@main

webkit-commit-queue · 2024-04-30T07:35:48Z

Committed 278159@main (ed28635): https://commits.webkit.org/278159@main

Reviewed commits have been landed. Closing PR #27682 and removing active labels.

aperezdc · 2024-05-02T10:35:28Z

Backported into the 2.44 branch as commit bd536df

magomez self-assigned this Apr 24, 2024

magomez added the WebKitGTK Bugs related to the Gtk API layer. label Apr 24, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 24, 2024

magomez removed the merging-blocked Applied to prevent a change from being merged label Apr 24, 2024

magomez force-pushed the eng/GTKWPE-Dont-allow-depth-test-and-stencil-clipping-if-packed-depth-stencil-is-not-supported branch from 93c2dd9 to 7cbe359 Compare April 24, 2024 12:15

magomez requested a review from carlosgcampos April 24, 2024 14:37

fujii reviewed Apr 24, 2024

View reviewed changes

magomez force-pushed the eng/GTKWPE-Dont-allow-depth-test-and-stencil-clipping-if-packed-depth-stencil-is-not-supported branch from 7cbe359 to a1b1510 Compare April 29, 2024 14:56

carlosgcampos approved these changes Apr 30, 2024

View reviewed changes

magomez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 30, 2024

webkit-commit-queue force-pushed the eng/GTKWPE-Dont-allow-depth-test-and-stencil-clipping-if-packed-depth-stencil-is-not-supported branch from a1b1510 to ed28635 Compare April 30, 2024 07:35

webkit-commit-queue merged commit ed28635 into WebKit:main Apr 30, 2024

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 30, 2024

aperezdc added the GLib Suggested Backport Suggest this merge request be backported to current WPE/GTK stable branch label May 2, 2024

aperezdc removed the GLib Suggested Backport Suggest this merge request be backported to current WPE/GTK stable branch label May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GTK][WPE] Don't allow depth test and stencil clipping if packed depth stencil is not supported #27682

[GTK][WPE] Don't allow depth test and stencil clipping if packed depth stencil is not supported #27682

magomez commented Apr 24, 2024 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Apr 24, 2024 •

edited

Loading

webkit-early-warning-system commented Apr 24, 2024 •

edited

Loading

fujii Apr 24, 2024

magomez Apr 25, 2024

carlosgcampos Apr 25, 2024

fujii commented Apr 24, 2024

magomez commented Apr 25, 2024

magomez commented Apr 29, 2024

webkit-early-warning-system commented Apr 29, 2024 •

edited

Loading

webkit-commit-queue commented Apr 30, 2024

aperezdc commented May 2, 2024

[GTK][WPE] Don't allow depth test and stencil clipping if packed depth stencil is not supported #27682

[GTK][WPE] Don't allow depth test and stencil clipping if packed depth stencil is not supported #27682

Conversation

magomez commented Apr 24, 2024 • edited by webkit-early-warning-system Loading

ed28635

webkit-early-warning-system commented Apr 24, 2024 • edited Loading

webkit-early-warning-system commented Apr 24, 2024 • edited Loading

fujii Apr 24, 2024

Choose a reason for hiding this comment

magomez Apr 25, 2024

Choose a reason for hiding this comment

carlosgcampos Apr 25, 2024

Choose a reason for hiding this comment

fujii commented Apr 24, 2024

magomez commented Apr 25, 2024

magomez commented Apr 29, 2024

webkit-early-warning-system commented Apr 29, 2024 • edited Loading

webkit-commit-queue commented Apr 30, 2024

aperezdc commented May 2, 2024

magomez commented Apr 24, 2024 •

edited by webkit-early-warning-system

Loading

`ed28635`

webkit-early-warning-system commented Apr 24, 2024 •

edited

Loading

webkit-early-warning-system commented Apr 24, 2024 •

edited

Loading

webkit-early-warning-system commented Apr 29, 2024 •

edited

Loading