Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash observed in running webxr layout test from WebCore::WebXRSession::~WebXRSession() #27735

Merged

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Apr 25, 2024

75f9692

Crash observed in running webxr layout test from WebCore::WebXRSession::~WebXRSession()
https://bugs.webkit.org/show_bug.cgi?id=272426

Reviewed by Mike Wyrzykowski.

Since `SimulatedXRDevice` inherits from `PlatformXR::Device` which is
reference counted, `WebFakeXRDevice::m_device` should be a `Ref`.

* Source/WebCore/testing/WebFakeXRDevice.cpp:
(WebCore::WebFakeXRDevice::WebFakeXRDevice):
(WebCore::WebFakeXRDevice::setViews):
(WebCore::WebFakeXRDevice::setViewerOrigin):
(WebCore::WebFakeXRDevice::simulateVisibilityChange):
(WebCore::WebFakeXRDevice::setFloorOrigin):
(WebCore::WebFakeXRDevice::simulateInputSourceConnection):
(WebCore::WebFakeXRDevice::setSupportsShutdownNotification):
(WebCore::WebFakeXRDevice::simulateShutdown):
* Source/WebCore/testing/WebFakeXRDevice.h:

Canonical link: https://commits.webkit.org/277983@main

67d1497

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@obyknovenius obyknovenius self-assigned this Apr 25, 2024
@obyknovenius obyknovenius added the WebXR For bugs in WebXR label Apr 25, 2024
@obyknovenius obyknovenius added the merge-queue Applied to send a pull request to merge-queue label Apr 25, 2024
…n::~WebXRSession()

https://bugs.webkit.org/show_bug.cgi?id=272426

Reviewed by Mike Wyrzykowski.

Since `SimulatedXRDevice` inherits from `PlatformXR::Device` which is
reference counted, `WebFakeXRDevice::m_device` should be a `Ref`.

* Source/WebCore/testing/WebFakeXRDevice.cpp:
(WebCore::WebFakeXRDevice::WebFakeXRDevice):
(WebCore::WebFakeXRDevice::setViews):
(WebCore::WebFakeXRDevice::setViewerOrigin):
(WebCore::WebFakeXRDevice::simulateVisibilityChange):
(WebCore::WebFakeXRDevice::setFloorOrigin):
(WebCore::WebFakeXRDevice::simulateInputSourceConnection):
(WebCore::WebFakeXRDevice::setSupportsShutdownNotification):
(WebCore::WebFakeXRDevice::simulateShutdown):
* Source/WebCore/testing/WebFakeXRDevice.h:

Canonical link: https://commits.webkit.org/277983@main
@webkit-commit-queue
Copy link
Collaborator

Committed 277983@main (75f9692): https://commits.webkit.org/277983@main

Reviewed commits have been landed. Closing PR #27735 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 75f9692 into WebKit:main Apr 25, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 25, 2024
@obyknovenius obyknovenius deleted the fix/webxr/device/pure-virutal branch May 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebXR For bugs in WebXR
Projects
None yet
4 participants