[macOS] REGRESSION(275831@main): Netflix can error out while scrubbing #27791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 34342ce) |
eric-carlson
approved these changes
Apr 26, 2024
| @@ -508,6 +508,12 @@ void MediaPlayerPrivateRemote::seeked(MediaTimeUpdateData&& timeData) | |||
| m_currentTimeEstimator.setTime(timeData); | |||
| if (auto player = m_player.get()) | |||
| player->seeked(timeData.currentTime); | |||
| #if ENABLE(MEDIA_SOURCE) | |||
| // This message may well have been handled by the MediaSource object before | |||
| // theis message, which would result in the wrong | |||
aestes
reviewed
Apr 26, 2024
| // This message may well have been handled by the MediaSource object before | ||
| // theis message, which would result in the wrong | ||
| if (m_mediaSourcePrivate) | ||
| return m_mediaSourcePrivate->seeked(timeData.currentTime); |
There was a problem hiding this comment.
Should be:
if (RefPtr mediaSourcePrivate = m_mediaSourcePrivate)
return mediaSourcePrivate->seeked(timeData.currentTime);
jernoble
force-pushed
the
eng/macOS-REGRESSION275831main-Netflix-can-error-out-while-scrubbing
branch
from
34342ce
to
02a26a1
Compare
|
EWS run on current version of this PR (hash 02a26a1) |
https://bugs.webkit.org/show_bug.cgi?id=273306 rdar://126654352 Reviewed by Eric Carlson. A race condition can occur where the MediaSource object in the WebContent process does not check the buffered ranges for the new currentTime after a seek, which leads to the readyState remaining at HAVE_METADATA, and the seeked event failing to fire. Ensure that the MediaSource checks its buffered ranges after a seek by adding an explicit "seeked()" method to MediaSourcePrivateClient to be used when a seek completes in a MediaPlayerPrivate, to notify the MediaSource to revalidate its buffered ranges. To avaid adding a new race condition, call this new "seeked()" method from MediaPlayerPrivateRemote, rather than from MediaSourcePrivateRemote, to ensure that the "official" time is fully updated before the MediaSource monitiors its source buffers. * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::failedToCreateRenderer): (WebCore::MediaSource::seeked): * Source/WebCore/Modules/mediasource/MediaSource.h: * Source/WebCore/platform/graphics/MediaSourcePrivate.cpp: (WebCore::MediaSourcePrivate::seeked): * Source/WebCore/platform/graphics/MediaSourcePrivate.h: * Source/WebCore/platform/graphics/MediaSourcePrivateClient.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: (WebCore::MediaSourcePrivateAVFObjC::seeked): * Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h: * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::seeked): Canonical link: https://commits.webkit.org/278060@main
webkit-commit-queue
force-pushed
the
eng/macOS-REGRESSION275831main-Netflix-can-error-out-while-scrubbing
branch
from
02a26a1
to
c7be93f
Compare
|
Committed 278060@main (c7be93f): https://commits.webkit.org/278060@main Reviewed commits have been landed. Closing PR #27791 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c7be93f
02a26a1
🛠 wpe🧪 wpe-wk2🧪 api-wpe🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🛠 watch