Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store in UIProcess whether VTB supports VP9 decode to query it only once in GPUProcess #2783

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Store in UIProcess whether VTB supports VP9 decode to query it only once in GPUProcess #2783

merged 1 commit into from
Jul 28, 2022

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Jul 27, 2022 •
edited by webkit-commit-queue

76c46a7

Store in UIProcess whether VTB supports VP9 decode to query it only once in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=243251

Reviewed by Eric Carlson.

WebCore::vp9HardwareDecoderAvailable might be an expensive operation, so it is best to do it as little as possible.
What we do is to add a parameter telling GPUProcess whether to query whether VP9 HW decoding is supported.
If query is needed, GPUProcess does it and sends the result to UIProcess, as well as WebProcess.
When UIProcess has it, UIProcess makes sure to no longer ask GPUProcess for querying it, and passes the stored value to let WebProcess knows it.

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
* Source/WebKit/Shared/GPUProcessConnectionParameters.h:
(WebKit::GPUProcessConnectionParameters::encode const):
(WebKit::GPUProcessConnectionParameters::decode):
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::createGPUProcessConnection):
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.messages.in:

Canonical link: https://commits.webkit.org/252902@main

@youennf youennf requested a review from cdumez as a code owner July 27, 2022 17:36
@youennf youennf self-assigned this Jul 27, 2022
@youennf youennf added WebKit Nightly Build WebRTC For bugs in WebRTC labels Jul 27, 2022
eric-carlson
eric-carlson approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@eric-carlson eric-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 28, 2022
@youennf youennf added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jul 28, 2022
@youennf
Store in UIProcess whether VTB supports VP9 decode to query it only o…
76c46a7 
…nce in GPUProcess

https://bugs.webkit.org/show_bug.cgi?id=243251

Reviewed by Eric Carlson.

WebCore::vp9HardwareDecoderAvailable might be an expensive operation, so it is best to do it as little as possible.
What we do is to add a parameter telling GPUProcess whether to query whether VP9 HW decoding is supported.
If query is needed, GPUProcess does it and sends the result to UIProcess, as well as WebProcess.
When UIProcess has it, UIProcess makes sure to no longer ask GPUProcess for querying it, and passes the stored value to let WebProcess knows it.

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
* Source/WebKit/Shared/GPUProcessConnectionParameters.h:
(WebKit::GPUProcessConnectionParameters::encode const):
(WebKit::GPUProcessConnectionParameters::decode):
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::createGPUProcessConnection):
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.messages.in:

Canonical link: https://commits.webkit.org/252902@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Store-in-UIProcess-whether-VTB-supports-VP9-decode-to-query-it-only-once-in-GPUProcess branch from 8ca871d to 76c46a7 Compare July 28, 2022 08:34
@webkit-commit-queue
Copy link
Collaborator

Committed 252902@main (76c46a7): https://commits.webkit.org/252902@main

Reviewed commits have been landed. Closing PR #2783 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 76c46a7 into WebKit:main Jul 28, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@youennf youennf

Labels
WebRTC For bugs in WebRTC
Projects
None yet
Milestone
No milestone
4 participants
@youennf @webkit-commit-queue @eric-carlson @webkit-early-warning-system